diff options
| author | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
|---|---|---|
| committer | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
| commit | 28bf37132d86cc59320e21d843960d086cef664c (patch) | |
| tree | bf085b5f89f1d1061b6a88ecc66c50721b13d86c /shmexport.c | |
| parent | ecb7e1ff3ec73000918c56861c55258c2d4deada (diff) | |
| download | gpsd-28bf37132d86cc59320e21d843960d086cef664c.tar.gz | |
Retire splint from our set of static analyzers.
The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches! A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.
But this has been coming for a while. Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained and somewhat
buggy and not easy to use.
Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.
All regression tests pass. PPS observed live on GR601-W.
Diffstat (limited to 'shmexport.c')
| -rw-r--r-- | shmexport.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/shmexport.c b/shmexport.c index b4283671..6e7dc274 100644 --- a/shmexport.c +++ b/shmexport.c @@ -30,14 +30,11 @@ PERMISSIONS #include "gpsd.h" #include "libgps.h" /* for SHM_PSEUDO_FD */ -/*@ -mustfreeonly -nullstate -mayaliasunique @*/ bool shm_acquire(struct gps_context_t *context) /* initialize the shared-memory segment to be used for export */ { - /*@-nullpass@*/ long shmkey = getenv("GPSD_SHM_KEY") ? strtol(getenv("GPSD_SHM_KEY"), NULL, 0) : GPSD_SHM_KEY; - /*@+nullpass@*/ int shmid = shmget((key_t)shmkey, sizeof(struct gps_data_t), (int)(IPC_CREAT|0666)); if (shmid == -1) { @@ -107,7 +104,6 @@ void shm_update(struct gps_context_t *context, struct gps_data_t *gpsdata) } } -/*@ +mustfreeonly +nullstate +mayaliasunique @*/ #endif /* SHM_EXPORT_ENABLE */ |