diff options
| author | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
|---|---|---|
| committer | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
| commit | 28bf37132d86cc59320e21d843960d086cef664c (patch) | |
| tree | bf085b5f89f1d1061b6a88ecc66c50721b13d86c /strl.c | |
| parent | ecb7e1ff3ec73000918c56861c55258c2d4deada (diff) | |
| download | gpsd-28bf37132d86cc59320e21d843960d086cef664c.tar.gz | |
Retire splint from our set of static analyzers.
The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches! A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.
But this has been coming for a while. Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained and somewhat
buggy and not easy to use.
Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.
All regression tests pass. PPS observed live on GR601-W.
Diffstat (limited to 'strl.c')
| -rw-r--r-- | strl.c | 6 |
1 files changed, 0 insertions, 6 deletions
@@ -20,7 +20,6 @@ * Returns strlen(src) + MIN(siz, strlen(initial dst)). * If retval >= siz, truncation occurred. */ -/*@ -compdef -mayaliasunique -mustdefine @*/ size_t strlcat(char *dst, const char *src, size_t siz) { size_t slen = strlen(src); @@ -35,7 +34,6 @@ size_t strlcat(char *dst, const char *src, size_t siz) } return dlen + slen; } -/*@ +compdef +mayaliasunique +mustdefine @*/ #ifdef __UNUSED__ /* $OpenBSD: strlcat.c,v 1.13 2005/08/08 08:05:37 espie Exp $ */ @@ -56,7 +54,6 @@ size_t strlcat(char *dst, const char *src, size_t siz) * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ -/*@ -usedef -mustdefine @*/ size_t strlcat(char *dst, const char *src, size_t siz) { char *d = dst; @@ -84,7 +81,6 @@ size_t strlcat(char *dst, const char *src, size_t siz) return (dlen + (s - src)); /* count does not include NUL */ } #endif /* __UNUSED__ */ -/*@ +usedef +mustdefine @*/ #endif /* HAVE_STRLCAT */ #ifndef HAVE_STRLCPY @@ -93,7 +89,6 @@ size_t strlcat(char *dst, const char *src, size_t siz) * will be copied. Always NUL terminates (unless siz == 0). * Returns strlen(src); if retval >= siz, truncation occurred. */ -/*@ -mayaliasunique -mustdefine @*/ size_t strlcpy(char *dst, const char *src, size_t siz) { size_t len = strlen(src); @@ -106,7 +101,6 @@ size_t strlcpy(char *dst, const char *src, size_t siz) } return len; } -/*@ -mayaliasunique -mustdefine @*/ #ifdef __UNUSED__ /* $OpenBSD: strlcpy.c,v 1.11 2006/05/05 15:27:38 millert Exp $ */ |