Do *not* clear DOPs every time a satellite picture comes from the receiver.

Required a regression-test rebuild.

The immediate reason for this was Savannah bug bug #37810:
satellites_used always zero via gpsd socket with multi nmea GSA/GSV. As the
user reporting said:

The "satellites_used" field in a "struct gps_data_t" filled in by
"gps_read" is always returning zero.

This module emits GNGSA messages in a group of three. My information
is that the first GNGSA pertains to GPS, second to GLONASS, third to
QZSS. It also emits GSV messages using talker id's GL,GP,QZ.

The larger point is that DOPs are likely to be valid for longer than
a GSV reporting cycle; they change only slowly as the actual sat
configuration does.  So it makes sense to retain them.

1 files changed, 6 insertions, 6 deletions

diff --git a/test/daemon/foretrex-201.log.chk b/test/daemon/foretrex-201.log.chk
index 91410b99..28467af3 100644
--- a/test/daemon/foretrex-201.log.chk
+++ b/test/daemon/foretrex-201.log.chk
@@ -807,7 +807,7 @@ $GPGSA,A,2,06,,,,,,19,22,,,,,2.7,2.5,1.0*3E
 $GPGSV,3,1,12,06,43,153,43,08,05,301,00,11,19,274,00,14,18,127,00*77

 $GPGSV,3,2,12,15,01,013,00,18,25,053,00,19,75,249,43,22,55,078,32*78

 $GPGSV,3,3,12,24,83,092,00,28,17,327,00,33,23,211,42,37,26,166,42*74

-{"class":"SKY","tag":"GSV","satellites":[{"PRN":6,"el":43,"az":153,"ss":43,"used":true},{"PRN":8,"el":5,"az":301,"ss":0,"used":false},{"PRN":11,"el":19,"az":274,"ss":0,"used":false},{"PRN":14,"el":18,"az":127,"ss":0,"used":false},{"PRN":15,"el":1,"az":13,"ss":0,"used":false},{"PRN":18,"el":25,"az":53,"ss":0,"used":false},{"PRN":19,"el":75,"az":249,"ss":43,"used":true},{"PRN":22,"el":55,"az":78,"ss":32,"used":true},{"PRN":24,"el":83,"az":92,"ss":0,"used":false},{"PRN":28,"el":17,"az":327,"ss":0,"used":false},{"PRN":120,"el":23,"az":211,"ss":42,"used":false},{"PRN":124,"el":26,"az":166,"ss":42,"used":false}]}

+{"class":"SKY","tag":"GSV","vdop":1.00,"hdop":2.50,"pdop":2.70,"satellites":[{"PRN":6,"el":43,"az":153,"ss":43,"used":true},{"PRN":8,"el":5,"az":301,"ss":0,"used":false},{"PRN":11,"el":19,"az":274,"ss":0,"used":false},{"PRN":14,"el":18,"az":127,"ss":0,"used":false},{"PRN":15,"el":1,"az":13,"ss":0,"used":false},{"PRN":18,"el":25,"az":53,"ss":0,"used":false},{"PRN":19,"el":75,"az":249,"ss":43,"used":true},{"PRN":22,"el":55,"az":78,"ss":32,"used":true},{"PRN":24,"el":83,"az":92,"ss":0,"used":false},{"PRN":28,"el":17,"az":327,"ss":0,"used":false},{"PRN":120,"el":23,"az":211,"ss":42,"used":false},{"PRN":124,"el":26,"az":166,"ss":42,"used":false}]}

 $GPGLL,5504.4343,N,01025.5386,E,200004,A,D*4E

 {"class":"TPV","tag":"GLL","mode":3,"time":"2010-08-26T20:00:04.000Z","ept":0.005,"lat":55.073905000,"lon":10.425643333,"alt":-9.100,"epv":5.750,"track":0.0000,"speed":0.000,"climb":0.000}

 $GPBOD,,T,,M,,*47

@@ -821,7 +821,7 @@ $GPGSA,A,2,06,,,,,,19,22,,,,,2.7,2.5,1.0*3E
 $GPGSV,3,1,12,06,43,153,43,08,05,301,00,11,19,274,00,14,18,127,00*77

 $GPGSV,3,2,12,15,01,013,00,18,25,053,00,19,75,249,43,22,55,078,31*7B

 $GPGSV,3,3,12,24,83,092,00,28,17,327,00,33,23,211,42,37,26,166,42*74

-{"class":"SKY","tag":"GSV","satellites":[{"PRN":6,"el":43,"az":153,"ss":43,"used":true},{"PRN":8,"el":5,"az":301,"ss":0,"used":false},{"PRN":11,"el":19,"az":274,"ss":0,"used":false},{"PRN":14,"el":18,"az":127,"ss":0,"used":false},{"PRN":15,"el":1,"az":13,"ss":0,"used":false},{"PRN":18,"el":25,"az":53,"ss":0,"used":false},{"PRN":19,"el":75,"az":249,"ss":43,"used":true},{"PRN":22,"el":55,"az":78,"ss":31,"used":true},{"PRN":24,"el":83,"az":92,"ss":0,"used":false},{"PRN":28,"el":17,"az":327,"ss":0,"used":false},{"PRN":120,"el":23,"az":211,"ss":42,"used":false},{"PRN":124,"el":26,"az":166,"ss":42,"used":false}]}

+{"class":"SKY","tag":"GSV","vdop":1.00,"hdop":2.50,"pdop":2.70,"satellites":[{"PRN":6,"el":43,"az":153,"ss":43,"used":true},{"PRN":8,"el":5,"az":301,"ss":0,"used":false},{"PRN":11,"el":19,"az":274,"ss":0,"used":false},{"PRN":14,"el":18,"az":127,"ss":0,"used":false},{"PRN":15,"el":1,"az":13,"ss":0,"used":false},{"PRN":18,"el":25,"az":53,"ss":0,"used":false},{"PRN":19,"el":75,"az":249,"ss":43,"used":true},{"PRN":22,"el":55,"az":78,"ss":31,"used":true},{"PRN":24,"el":83,"az":92,"ss":0,"used":false},{"PRN":28,"el":17,"az":327,"ss":0,"used":false},{"PRN":120,"el":23,"az":211,"ss":42,"used":false},{"PRN":124,"el":26,"az":166,"ss":42,"used":false}]}

 $GPGLL,5504.4343,N,01025.5386,E,200006,A,D*4C

 {"class":"TPV","tag":"GLL","mode":3,"time":"2010-08-26T20:00:06.000Z","ept":0.005,"lat":55.073905000,"lon":10.425643333,"alt":-9.100,"epv":5.750,"track":0.0000,"speed":0.000,"climb":0.000}

 $GPBOD,,T,,M,,*47

@@ -835,7 +835,7 @@ $GPGSA,A,2,06,,,,,,19,22,,,,,2.7,2.5,1.0*3E
 $GPGSV,3,1,12,06,43,153,44,08,04,301,00,11,19,274,00,14,18,127,00*71

 $GPGSV,3,2,12,15,01,013,00,18,25,053,00,19,75,249,43,22,55,078,31*7B

 $GPGSV,3,3,12,24,83,092,00,28,17,327,00,33,23,211,42,37,26,166,42*74

-{"class":"SKY","tag":"GSV","satellites":[{"PRN":6,"el":43,"az":153,"ss":44,"used":true},{"PRN":8,"el":4,"az":301,"ss":0,"used":false},{"PRN":11,"el":19,"az":274,"ss":0,"used":false},{"PRN":14,"el":18,"az":127,"ss":0,"used":false},{"PRN":15,"el":1,"az":13,"ss":0,"used":false},{"PRN":18,"el":25,"az":53,"ss":0,"used":false},{"PRN":19,"el":75,"az":249,"ss":43,"used":true},{"PRN":22,"el":55,"az":78,"ss":31,"used":true},{"PRN":24,"el":83,"az":92,"ss":0,"used":false},{"PRN":28,"el":17,"az":327,"ss":0,"used":false},{"PRN":120,"el":23,"az":211,"ss":42,"used":false},{"PRN":124,"el":26,"az":166,"ss":42,"used":false}]}

+{"class":"SKY","tag":"GSV","vdop":1.00,"hdop":2.50,"pdop":2.70,"satellites":[{"PRN":6,"el":43,"az":153,"ss":44,"used":true},{"PRN":8,"el":4,"az":301,"ss":0,"used":false},{"PRN":11,"el":19,"az":274,"ss":0,"used":false},{"PRN":14,"el":18,"az":127,"ss":0,"used":false},{"PRN":15,"el":1,"az":13,"ss":0,"used":false},{"PRN":18,"el":25,"az":53,"ss":0,"used":false},{"PRN":19,"el":75,"az":249,"ss":43,"used":true},{"PRN":22,"el":55,"az":78,"ss":31,"used":true},{"PRN":24,"el":83,"az":92,"ss":0,"used":false},{"PRN":28,"el":17,"az":327,"ss":0,"used":false},{"PRN":120,"el":23,"az":211,"ss":42,"used":false},{"PRN":124,"el":26,"az":166,"ss":42,"used":false}]}

 $GPGLL,5504.4344,N,01025.5385,E,200008,A,D*46

 {"class":"TPV","tag":"GLL","mode":3,"time":"2010-08-26T20:00:08.000Z","ept":0.005,"lat":55.073906667,"lon":10.425641667,"alt":-9.100,"epv":5.750,"track":0.0000,"speed":0.000,"climb":0.000}

 $GPBOD,,T,,M,,*47

@@ -849,7 +849,7 @@ $GPGSA,A,2,,,,,,,,,,,,,2.7,2.5,1.0*30
 $GPGSV,3,1,12,06,43,153,44,08,04,301,00,11,19,274,00,14,18,127,00*71

 $GPGSV,3,2,12,15,01,013,00,18,25,053,00,19,75,249,43,22,55,078,31*7B

 $GPGSV,3,3,12,24,83,092,00,28,17,327,00,33,23,211,42,37,26,166,42*74

-{"class":"SKY","tag":"GSV","satellites":[{"PRN":6,"el":43,"az":153,"ss":44,"used":false},{"PRN":8,"el":4,"az":301,"ss":0,"used":false},{"PRN":11,"el":19,"az":274,"ss":0,"used":false},{"PRN":14,"el":18,"az":127,"ss":0,"used":false},{"PRN":15,"el":1,"az":13,"ss":0,"used":false},{"PRN":18,"el":25,"az":53,"ss":0,"used":false},{"PRN":19,"el":75,"az":249,"ss":43,"used":false},{"PRN":22,"el":55,"az":78,"ss":31,"used":false},{"PRN":24,"el":83,"az":92,"ss":0,"used":false},{"PRN":28,"el":17,"az":327,"ss":0,"used":false},{"PRN":120,"el":23,"az":211,"ss":42,"used":false},{"PRN":124,"el":26,"az":166,"ss":42,"used":false}]}

+{"class":"SKY","tag":"GSV","vdop":1.00,"hdop":2.50,"pdop":2.70,"satellites":[{"PRN":6,"el":43,"az":153,"ss":44,"used":false},{"PRN":8,"el":4,"az":301,"ss":0,"used":false},{"PRN":11,"el":19,"az":274,"ss":0,"used":false},{"PRN":14,"el":18,"az":127,"ss":0,"used":false},{"PRN":15,"el":1,"az":13,"ss":0,"used":false},{"PRN":18,"el":25,"az":53,"ss":0,"used":false},{"PRN":19,"el":75,"az":249,"ss":43,"used":false},{"PRN":22,"el":55,"az":78,"ss":31,"used":false},{"PRN":24,"el":83,"az":92,"ss":0,"used":false},{"PRN":28,"el":17,"az":327,"ss":0,"used":false},{"PRN":120,"el":23,"az":211,"ss":42,"used":false},{"PRN":124,"el":26,"az":166,"ss":42,"used":false}]}

 $GPGLL,5504.4344,N,01025.5385,E,200010,A,D*4F

 {"class":"TPV","tag":"GLL","mode":3,"time":"2010-08-26T20:00:10.000Z","ept":0.005,"lat":55.073906667,"lon":10.425641667,"alt":-9.100,"epv":5.750,"track":0.0000,"speed":0.000,"climb":0.000}

 $GPBOD,,T,,M,,*47

@@ -863,7 +863,7 @@ $GPGSA,A,2,,,,,,,,,,,,,2.7,2.5,1.0*30
 $GPGSV,3,1,12,06,43,153,44,08,04,301,00,11,19,274,00,14,18,127,00*71

 $GPGSV,3,2,12,15,01,013,00,18,25,053,00,19,75,249,43,22,55,078,31*7B

 $GPGSV,3,3,12,24,83,092,00,28,17,327,00,33,23,211,42,37,26,166,42*74

-{"class":"SKY","tag":"GSV","satellites":[{"PRN":6,"el":43,"az":153,"ss":44,"used":false},{"PRN":8,"el":4,"az":301,"ss":0,"used":false},{"PRN":11,"el":19,"az":274,"ss":0,"used":false},{"PRN":14,"el":18,"az":127,"ss":0,"used":false},{"PRN":15,"el":1,"az":13,"ss":0,"used":false},{"PRN":18,"el":25,"az":53,"ss":0,"used":false},{"PRN":19,"el":75,"az":249,"ss":43,"used":false},{"PRN":22,"el":55,"az":78,"ss":31,"used":false},{"PRN":24,"el":83,"az":92,"ss":0,"used":false},{"PRN":28,"el":17,"az":327,"ss":0,"used":false},{"PRN":120,"el":23,"az":211,"ss":42,"used":false},{"PRN":124,"el":26,"az":166,"ss":42,"used":false}]}

+{"class":"SKY","tag":"GSV","vdop":1.00,"hdop":2.50,"pdop":2.70,"satellites":[{"PRN":6,"el":43,"az":153,"ss":44,"used":false},{"PRN":8,"el":4,"az":301,"ss":0,"used":false},{"PRN":11,"el":19,"az":274,"ss":0,"used":false},{"PRN":14,"el":18,"az":127,"ss":0,"used":false},{"PRN":15,"el":1,"az":13,"ss":0,"used":false},{"PRN":18,"el":25,"az":53,"ss":0,"used":false},{"PRN":19,"el":75,"az":249,"ss":43,"used":false},{"PRN":22,"el":55,"az":78,"ss":31,"used":false},{"PRN":24,"el":83,"az":92,"ss":0,"used":false},{"PRN":28,"el":17,"az":327,"ss":0,"used":false},{"PRN":120,"el":23,"az":211,"ss":42,"used":false},{"PRN":124,"el":26,"az":166,"ss":42,"used":false}]}

 $GPGLL,5504.4344,N,01025.5385,E,200012,A,D*4D

 {"class":"TPV","tag":"GLL","mode":3,"time":"2010-08-26T20:00:12.000Z","ept":0.005,"lat":55.073906667,"lon":10.425641667,"alt":-9.100,"epv":5.750,"track":0.0000,"speed":0.000,"climb":0.000}

 $GPBOD,,T,,M,,*47

@@ -877,7 +877,7 @@ $GPGSA,A,2,,,,,,,,,,,,,2.7,2.5,1.0*30
 $GPGSV,3,1,12,06,43,153,44,08,04,301,00,11,19,274,00,14,18,127,00*71

 $GPGSV,3,2,12,15,01,013,00,18,25,053,00,19,75,249,43,22,55,078,31*7B

 $GPGSV,3,3,12,24,83,092,00,28,17,327,00,33,23,211,42,37,26,166,42*74

-{"class":"SKY","tag":"GSV","satellites":[{"PRN":6,"el":43,"az":153,"ss":44,"used":false},{"PRN":8,"el":4,"az":301,"ss":0,"used":false},{"PRN":11,"el":19,"az":274,"ss":0,"used":false},{"PRN":14,"el":18,"az":127,"ss":0,"used":false},{"PRN":15,"el":1,"az":13,"ss":0,"used":false},{"PRN":18,"el":25,"az":53,"ss":0,"used":false},{"PRN":19,"el":75,"az":249,"ss":43,"used":false},{"PRN":22,"el":55,"az":78,"ss":31,"used":false},{"PRN":24,"el":83,"az":92,"ss":0,"used":false},{"PRN":28,"el":17,"az":327,"ss":0,"used":false},{"PRN":120,"el":23,"az":211,"ss":42,"used":false},{"PRN":124,"el":26,"az":166,"ss":42,"used":false}]}

+{"class":"SKY","tag":"GSV","vdop":1.00,"hdop":2.50,"pdop":2.70,"satellites":[{"PRN":6,"el":43,"az":153,"ss":44,"used":false},{"PRN":8,"el":4,"az":301,"ss":0,"used":false},{"PRN":11,"el":19,"az":274,"ss":0,"used":false},{"PRN":14,"el":18,"az":127,"ss":0,"used":false},{"PRN":15,"el":1,"az":13,"ss":0,"used":false},{"PRN":18,"el":25,"az":53,"ss":0,"used":false},{"PRN":19,"el":75,"az":249,"ss":43,"used":false},{"PRN":22,"el":55,"az":78,"ss":31,"used":false},{"PRN":24,"el":83,"az":92,"ss":0,"used":false},{"PRN":28,"el":17,"az":327,"ss":0,"used":false},{"PRN":120,"el":23,"az":211,"ss":42,"used":false},{"PRN":124,"el":26,"az":166,"ss":42,"used":false}]}

 $GPGLL,5504.4344,N,01025.5384,E,200014,A,D*4A

 {"class":"TPV","tag":"GLL","mode":3,"time":"2010-08-26T20:00:14.000Z","ept":0.005,"lat":55.073906667,"lon":10.425640000,"alt":-9.100,"epv":5.750,"track":0.0000,"speed":0.000,"climb":0.000}

 $GPBOD,,T,,M,,*47