Fix pseudo GSA generation

At one point, the check for MODE_SET made sense in
gpsd_binary_quality_dump().  But since then, the calling code was
refactored to only invoke nmea_tpv_dump() when REPORT_IS is set,
eliminating the dupes.

Remove the MODE_SET check and update the affected binary regression
check files to contain the expected GSA sentences.

Signed-off-by: Gary E. Miller <gem@rellim.com>

1 files changed, 4 insertions, 0 deletions

diff --git a/test/daemon/geostar-geos1m-binary.log.chk b/test/daemon/geostar-geos1m-binary.log.chk
index 9edada0f..d5c07938 100644
--- a/test/daemon/geostar-geos1m-binary.log.chk
+++ b/test/daemon/geostar-geos1m-binary.log.chk
@@ -7,6 +7,7 @@ $GPGSV,6,6,21,31,39,300,00*41
 {"class":"SKY","xdop":1.56,"ydop":0.93,"vdop":1.48,"tdop":1.63,"hdop":1.82,"gdop":2.86,"pdop":2.34,"satellites":[{"PRN":67,"el":12,"az":2,"ss":40,"used":true},{"PRN":68,"el":22,"az":53,"ss":51,"used":true},{"PRN":69,"el":8,"az":102,"ss":40,"used":true},{"PRN":74,"el":38,"az":187,"ss":0,"used":false},{"PRN":75,"el":63,"az":278,"ss":0,"used":false},{"PRN":83,"el":15,"az":57,"ss":41,"used":true},{"PRN":84,"el":69,"az":39,"ss":44,"used":true},{"PRN":85,"el":51,"az":252,"ss":0,"used":false},{"PRN":86,"el":1,"az":243,"ss":0,"used":false},{"PRN":2,"el":43,"az":65,"ss":50,"used":true},{"PRN":4,"el":11,"az":40,"ss":45,"used":true},{"PRN":5,"el":9,"az":115,"ss":39,"used":true},{"PRN":10,"el":17,"az":76,"ss":42,"used":true},{"PRN":12,"el":47,"az":124,"ss":41,"used":true},{"PRN":14,"el":2,"az":251,"ss":24,"used":false},{"PRN":21,"el":2,"az":200,"ss":0,"used":false},{"PRN":23,"el":2,"az":2,"ss":45,"used":false},{"PRN":25,"el":80,"az":156,"ss":25,"used":false},{"PRN":29,"el":58,"az":246,"ss":0,"used":false},{"PRN":30,"el":82,"az":177,"ss":0,"used":false},{"PRN":31,"el":39,"az":300,"ss":0,"used":false}]}

 $GPGGA,125026,5355.1637,N,02730.0245,E,1,10,1.57,273.92,M,23.270,M,,*4B

 $GPRMC,125026,A,5355.1637,N,02730.0245,E,0.0319,207.214,070910,,*29

+$GPGSA,A,3,67,68,69,83,84,2,4,5,,,,,2.3,1.6,1.7*06

 {"class":"TPV","mode":3,"time":"2010-09-07T12:50:26.000Z","ept":0.005,"lat":53.919395650,"lon":27.500408874,"alt":273.924,"epx":23.432,"epy":13.910,"epv":34.010,"track":207.2138,"speed":0.016}

 $GPGSV,6,1,21,67,12,002,40,68,22,053,52,69,08,102,40,74,38,187,00*70

 $GPGSV,6,2,21,75,63,278,00,83,15,057,41,84,69,039,45,85,51,252,00*78

@@ -17,6 +18,7 @@ $GPGSV,6,6,21,31,39,300,00*41
 {"class":"SKY","xdop":1.56,"ydop":0.93,"vdop":1.73,"tdop":1.62,"hdop":1.57,"gdop":2.85,"pdop":2.34,"satellites":[{"PRN":67,"el":12,"az":2,"ss":40,"used":true},{"PRN":68,"el":22,"az":53,"ss":52,"used":true},{"PRN":69,"el":8,"az":102,"ss":40,"used":true},{"PRN":74,"el":38,"az":187,"ss":0,"used":false},{"PRN":75,"el":63,"az":278,"ss":0,"used":false},{"PRN":83,"el":15,"az":57,"ss":41,"used":true},{"PRN":84,"el":69,"az":39,"ss":45,"used":true},{"PRN":85,"el":51,"az":252,"ss":0,"used":false},{"PRN":86,"el":1,"az":243,"ss":0,"used":false},{"PRN":2,"el":43,"az":65,"ss":50,"used":true},{"PRN":4,"el":11,"az":40,"ss":46,"used":true},{"PRN":5,"el":9,"az":115,"ss":38,"used":true},{"PRN":10,"el":17,"az":76,"ss":42,"used":true},{"PRN":12,"el":47,"az":124,"ss":41,"used":true},{"PRN":14,"el":2,"az":251,"ss":24,"used":false},{"PRN":21,"el":2,"az":200,"ss":0,"used":false},{"PRN":23,"el":2,"az":2,"ss":45,"used":false},{"PRN":25,"el":80,"az":156,"ss":26,"used":false},{"PRN":29,"el":58,"az":246,"ss":0,"used":false},{"PRN":30,"el":82,"az":177,"ss":0,"used":false},{"PRN":31,"el":39,"az":300,"ss":0,"used":false}]}

 $GPGGA,125027,5355.1638,N,02730.0245,E,1,10,1.57,273.77,M,23.270,M,,*4E

 $GPRMC,125027,A,5355.1638,N,02730.0245,E,0.0338,208.578,070910,,*26

+$GPGSA,A,3,67,68,69,83,84,2,4,5,,,,,2.3,1.6,1.7*06

 $GPGBS,125027,23.43,M,13.91,M,34.01,M*07

 {"class":"TPV","mode":3,"time":"2010-09-07T12:50:27.000Z","ept":0.005,"lat":53.919396388,"lon":27.500408124,"alt":273.773,"epx":23.432,"epy":13.910,"epv":34.010,"track":208.5776,"speed":0.017,"climb":0.000,"eps":46.86,"epc":68.02}

 $GPGSV,6,1,21,67,12,002,41,68,22,053,52,69,08,102,40,74,38,187,00*71

@@ -28,6 +30,7 @@ $GPGSV,6,6,21,31,39,300,00*41
 {"class":"SKY","xdop":1.56,"ydop":0.93,"vdop":1.73,"tdop":1.62,"hdop":1.57,"gdop":2.85,"pdop":2.34,"satellites":[{"PRN":67,"el":12,"az":2,"ss":41,"used":true},{"PRN":68,"el":22,"az":53,"ss":52,"used":true},{"PRN":69,"el":8,"az":102,"ss":40,"used":true},{"PRN":74,"el":38,"az":187,"ss":0,"used":false},{"PRN":75,"el":63,"az":278,"ss":0,"used":false},{"PRN":83,"el":15,"az":57,"ss":41,"used":true},{"PRN":84,"el":69,"az":39,"ss":44,"used":true},{"PRN":85,"el":51,"az":252,"ss":0,"used":false},{"PRN":86,"el":1,"az":243,"ss":0,"used":false},{"PRN":2,"el":43,"az":65,"ss":50,"used":true},{"PRN":4,"el":11,"az":40,"ss":46,"used":true},{"PRN":5,"el":9,"az":115,"ss":38,"used":true},{"PRN":10,"el":17,"az":76,"ss":41,"used":true},{"PRN":12,"el":47,"az":124,"ss":41,"used":true},{"PRN":14,"el":2,"az":251,"ss":22,"used":false},{"PRN":21,"el":2,"az":200,"ss":0,"used":false},{"PRN":23,"el":2,"az":2,"ss":45,"used":false},{"PRN":25,"el":80,"az":156,"ss":25,"used":false},{"PRN":29,"el":58,"az":246,"ss":0,"used":false},{"PRN":30,"el":82,"az":177,"ss":0,"used":false},{"PRN":31,"el":39,"az":300,"ss":0,"used":false}]}

 $GPGGA,125028,5355.1638,N,02730.0246,E,1,10,1.57,273.77,M,23.260,M,,*43

 $GPRMC,125028,A,5355.1638,N,02730.0246,E,0.0304,198.298,070910,,*26

+$GPGSA,A,3,67,68,69,83,84,2,4,5,,,,,2.3,1.6,1.7*06

 $GPGBS,125028,23.43,M,13.91,M,34.01,M*08

 {"class":"TPV","mode":3,"time":"2010-09-07T12:50:28.000Z","ept":0.005,"lat":53.919396987,"lon":27.500409347,"alt":273.769,"epx":23.432,"epy":13.910,"epv":34.010,"track":198.2983,"speed":0.016,"climb":0.000,"eps":46.86,"epc":68.02}

 $GPGSV,6,1,21,67,12,002,41,68,22,053,52,69,08,102,40,74,38,187,00*71

@@ -39,5 +42,6 @@ $GPGSV,6,6,21,31,39,300,00*41
 {"class":"SKY","xdop":1.56,"ydop":0.93,"vdop":1.73,"tdop":1.62,"hdop":1.57,"gdop":2.85,"pdop":2.34,"satellites":[{"PRN":67,"el":12,"az":2,"ss":41,"used":true},{"PRN":68,"el":22,"az":53,"ss":52,"used":true},{"PRN":69,"el":8,"az":102,"ss":40,"used":true},{"PRN":74,"el":38,"az":187,"ss":0,"used":false},{"PRN":75,"el":63,"az":278,"ss":0,"used":false},{"PRN":83,"el":15,"az":58,"ss":41,"used":true},{"PRN":84,"el":69,"az":39,"ss":44,"used":true},{"PRN":85,"el":51,"az":252,"ss":0,"used":false},{"PRN":86,"el":1,"az":243,"ss":0,"used":false},{"PRN":2,"el":43,"az":65,"ss":50,"used":true},{"PRN":4,"el":11,"az":40,"ss":46,"used":true},{"PRN":5,"el":9,"az":115,"ss":38,"used":true},{"PRN":10,"el":17,"az":76,"ss":41,"used":true},{"PRN":12,"el":47,"az":124,"ss":41,"used":true},{"PRN":14,"el":2,"az":251,"ss":23,"used":false},{"PRN":21,"el":2,"az":200,"ss":0,"used":false},{"PRN":23,"el":2,"az":2,"ss":45,"used":false},{"PRN":25,"el":80,"az":156,"ss":25,"used":false},{"PRN":29,"el":58,"az":246,"ss":0,"used":false},{"PRN":30,"el":82,"az":177,"ss":0,"used":false},{"PRN":31,"el":39,"az":300,"ss":0,"used":false}]}

 $GPGGA,125029,5355.1639,N,02730.0248,E,1,10,1.57,273.92,M,23.252,M,,*47

 $GPRMC,125029,A,5355.1639,N,02730.0248,E,0.0266,178.518,070910,,*2C

+$GPGSA,A,3,67,68,69,83,84,2,4,5,,,,,2.3,1.6,1.7*06

 $GPGBS,125029,23.43,M,13.91,M,34.01,M*09

 {"class":"TPV","mode":3,"time":"2010-09-07T12:50:29.000Z","ept":0.005,"lat":53.919397821,"lon":27.500413011,"alt":273.924,"epx":23.432,"epy":13.910,"epv":34.010,"track":178.5179,"speed":0.014,"climb":0.000,"eps":46.86,"epc":68.02}