Do *not* clear DOPs every time a satellite picture comes from the receiver.

Required a regression-test rebuild.

The immediate reason for this was Savannah bug bug #37810:
satellites_used always zero via gpsd socket with multi nmea GSA/GSV. As the
user reporting said:

The "satellites_used" field in a "struct gps_data_t" filled in by
"gps_read" is always returning zero.

This module emits GNGSA messages in a group of three. My information
is that the first GNGSA pertains to GPS, second to GLONASS, third to
QZSS. It also emits GSV messages using talker id's GL,GP,QZ.

The larger point is that DOPs are likely to be valid for longer than
a GSV reporting cycle; they change only slowly as the actual sat
configuration does.  So it makes sense to retain them.

1 files changed, 7 insertions, 7 deletions

diff --git a/test/daemon/gp-320fw-2019-04-07-coldboot.log.chk b/test/daemon/gp-320fw-2019-04-07-coldboot.log.chk
index 1770095c..12945e19 100644
--- a/test/daemon/gp-320fw-2019-04-07-coldboot.log.chk
+++ b/test/daemon/gp-320fw-2019-04-07-coldboot.log.chk
@@ -43,7 +43,7 @@ $GPGSA,A,1,,,,,,,,,,,,,,,*1E
 $GPGSV,3,1,12,23,86,270,,13,70,270,40,24,59,270,,04,41,270,40*79

 $GPGSV,3,2,12,25,31,090,,01,22,090,,17,13,270,,05,12,090,*71

 $GPGSV,3,3,12,20,09,090,40,06,08,270,,16,00,090,,31,26,090,40*72

-{"class":"SKY","tag":"GSV","satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":41,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":40,"used":false}]}

+{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":0.00,"pdop":0.00,"satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":41,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":40,"used":false}]}

 $GPGLL,0000.0000,N,00000.0000,E,000429.00,V,N*7E

 {"class":"TPV","tag":"GLL","mode":0,"time":"1999-08-22T00:04:29.000Z","ept":0.005}

 $GPZDA,000429.00,22,08,1999,,*69

@@ -54,7 +54,7 @@ $GPGSA,A,1,,,,,,,,,,,,,,,*1E
 $GPGSV,3,1,12,23,86,270,,13,70,270,40,24,59,270,,04,41,270,40*79

 $GPGSV,3,2,12,25,31,090,,01,22,090,,17,13,270,,05,12,090,*71

 $GPGSV,3,3,12,20,09,090,40,06,08,270,,16,00,090,,31,26,090,40*72

-{"class":"SKY","tag":"GSV","satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":41,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":40,"used":false}]}

+{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":0.00,"pdop":0.00,"satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":41,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":40,"used":false}]}

 $GPGLL,0000.0000,N,00000.0000,E,000430.00,V,N*76

 {"class":"TPV","tag":"GLL","mode":0,"time":"1999-08-22T00:04:30.000Z","ept":0.005}

 $GPZDA,000430.00,22,08,1999,,*61

@@ -65,7 +65,7 @@ $GPGSA,A,1,,,,,,,,,,,,,,,*1E
 $GPGSV,3,1,12,23,86,270,,13,70,270,40,24,59,270,,04,41,270,40*79

 $GPGSV,3,2,12,25,31,090,,01,22,090,,17,13,270,,05,12,090,*71

 $GPGSV,3,3,12,20,09,090,40,06,08,270,,31,26,090,40,16,00,090,*72

-{"class":"SKY","tag":"GSV","satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":41,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":40,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false}]}

+{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":0.00,"pdop":0.00,"satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":41,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":40,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false}]}

 $GPGLL,0000.0000,N,00000.0000,E,000431.00,V,N*77

 {"class":"TPV","tag":"GLL","mode":0,"time":"1999-08-22T00:04:31.000Z","ept":0.005}

 $GPZDA,000431.00,22,08,1999,,*60

@@ -76,7 +76,7 @@ $GPGSA,A,1,,,,,,,,,,,,,,,*1E
 $GPGSV,3,1,12,23,86,270,,13,70,270,40,24,59,270,,04,41,270,40*79

 $GPGSV,3,2,12,25,31,090,,01,22,090,,17,13,270,,05,12,090,*71

 $GPGSV,3,3,12,20,09,090,40,06,08,270,,31,26,090,41,16,00,090,*73

-{"class":"SKY","tag":"GSV","satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":41,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":41,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false}]}

+{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":0.00,"pdop":0.00,"satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":41,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":41,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false}]}

 $GPGLL,0000.0000,N,00000.0000,E,000432.00,V,N*74

 {"class":"TPV","tag":"GLL","mode":0,"time":"1999-08-22T00:04:32.000Z","ept":0.005}

 $GPZDA,000432.00,22,08,1999,,*63

@@ -87,7 +87,7 @@ $GPGSA,A,1,,,,,,,,,,,,,,,*1E
 $GPGSV,3,1,12,23,86,270,,13,70,270,40,24,59,270,,04,41,270,40*79

 $GPGSV,3,2,12,25,31,090,,01,22,090,,17,13,270,,05,12,090,*71

 $GPGSV,3,3,12,20,09,090,40,06,08,270,,31,26,090,41,16,00,090,*73

-{"class":"SKY","tag":"GSV","satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":41,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":41,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false}]}

+{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":0.00,"pdop":0.00,"satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":41,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":41,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false}]}

 $GPGLL,0000.0000,N,00000.0000,E,000433.00,V,N*75

 {"class":"TPV","tag":"GLL","mode":0,"time":"1999-08-22T00:04:33.000Z","ept":0.005}

 $GPZDA,000433.00,22,08,1999,,*62

@@ -98,7 +98,7 @@ $GPGSA,A,1,,,,,,,,,,,,,,,*1E
 $GPGSV,3,1,12,23,86,270,,13,70,270,40,24,59,270,,04,41,270,40*79

 $GPGSV,3,2,12,25,31,090,,01,22,090,,17,13,270,,05,12,090,*71

 $GPGSV,3,3,12,20,09,090,40,06,08,270,,31,26,090,41,16,00,090,*73

-{"class":"SKY","tag":"GSV","satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":41,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":41,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false}]}

+{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":0.00,"pdop":0.00,"satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":41,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":41,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false}]}

 $GPGLL,0000.0000,N,00000.0000,E,000434.00,V,N*72

 {"class":"TPV","tag":"GLL","mode":0,"time":"1999-08-22T00:04:34.000Z","ept":0.005}

 $GPZDA,000434.00,22,08,1999,,*65

@@ -109,4 +109,4 @@ $GPGSA,A,1,,,,,,,,,,,,,,,*1E
 $GPGSV,3,1,12,23,86,270,,13,70,270,40,24,59,270,,04,20,270,40*7E

 $GPGSV,3,2,12,25,31,090,,01,22,090,,17,13,270,,05,12,090,*71

 $GPGSV,3,3,12,20,09,090,40,06,08,270,,31,26,090,41,16,00,090,*73

-{"class":"SKY","tag":"GSV","satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":20,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":41,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false}]}

+{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":0.00,"pdop":0.00,"satellites":[{"PRN":23,"el":86,"az":270,"ss":0,"used":false},{"PRN":13,"el":70,"az":270,"ss":40,"used":false},{"PRN":24,"el":59,"az":270,"ss":0,"used":false},{"PRN":4,"el":20,"az":270,"ss":40,"used":false},{"PRN":25,"el":31,"az":90,"ss":0,"used":false},{"PRN":1,"el":22,"az":90,"ss":0,"used":false},{"PRN":17,"el":13,"az":270,"ss":0,"used":false},{"PRN":5,"el":12,"az":90,"ss":0,"used":false},{"PRN":20,"el":9,"az":90,"ss":40,"used":false},{"PRN":6,"el":8,"az":270,"ss":0,"used":false},{"PRN":31,"el":26,"az":90,"ss":41,"used":false},{"PRN":16,"el":0,"az":90,"ss":0,"used":false}]}