Change NMEA mode setting, thus major changes in gpsd_error_model().

The start of this overly large patch was to simply move the test
for MODE_2D/3D flipping, which only affect NMEA 183, back into
driver_nmea0813.c

But that was intertwined with how gpsd_error_model() computes
derived variables, which required major changes to how NMEA 183
mode_2D/3D are set.

This ultimatly led to major regression test results.  Almost all for
the better.

I tried to break it up, but moving from one paradigm to another
needed one big jump...

1 files changed, 5 insertions, 5 deletions

diff --git a/test/daemon/gr8013-w.log.chk b/test/daemon/gr8013-w.log.chk
index bb94b8cf..8636ff55 100644
--- a/test/daemon/gr8013-w.log.chk
+++ b/test/daemon/gr8013-w.log.chk
@@ -4,9 +4,9 @@ $GNVTG,,T,,M,0.031,N,0.058,K,A*32
 $GNGGA,181141.00,5230.88855,N,01327.85591,E,1,12,0.93,62.6,M,42.1,M,,*79
 {"class":"TPV","mode":3,"time":"2015-06-19T18:11:41.000Z","ept":0.005,"lat":52.514809167,"lon":13.464265167,"alt":62.600,"track":0.0000,"speed":0.016}

 $GNGSA,A,3,21,13,27,18,20,26,07,16,22,15,19,,1.59,0.93,1.29*16
-{"class":"TPV","mode":3,"time":"2015-06-19T18:11:41.000Z","ept":0.005,"lat":52.514809167,"lon":13.464265167,"alt":62.600,"epv":29.670,"track":0.0000,"speed":0.016,"climb":0.000}

+{"class":"TPV","mode":3,"time":"2015-06-19T18:11:41.000Z","ept":0.005,"lat":52.514809167,"lon":13.464265167,"alt":62.600,"epv":29.670,"track":0.0000,"speed":0.016}

 $GNGSA,A,3,71,85,69,86,77,87,70,76,,,,,1.59,0.93,1.29*12
-{"class":"TPV","mode":3,"time":"2015-06-19T18:11:41.000Z","ept":0.005,"lat":52.514809167,"lon":13.464265167,"alt":62.600,"epv":29.670,"track":0.0000,"speed":0.016,"climb":0.000}

+{"class":"TPV","mode":3,"time":"2015-06-19T18:11:41.000Z","ept":0.005,"lat":52.514809167,"lon":13.464265167,"alt":62.600,"epv":29.670,"track":0.0000,"speed":0.016}

 $GPGSV,4,1,14,04,07,250,09,07,13,306,37,08,12,175,15,13,08,020,37*70
 $GPGSV,4,2,14,15,15,051,29,16,49,210,23,18,56,102,27,19,38,293,33*7A
 $GPGSV,4,3,14,20,07,040,18,21,36,072,31,22,46,164,26,26,25,186,21*78
@@ -17,7 +17,7 @@ $GLGSV,3,2,10,77,28,318,33,78,03,003,,84,05,098,12,85,51,083,26*67
 $GLGSV,3,3,10,86,64,319,44,87,12,289,25*6B
 {"class":"SKY","xdop":0.39,"ydop":0.47,"vdop":1.29,"tdop":0.60,"hdop":0.93,"gdop":1.31,"pdop":1.59,"satellites":[{"PRN":4,"el":7,"az":250,"ss":9,"used":false,"gnssid":0,"svid":4},{"PRN":7,"el":13,"az":306,"ss":37,"used":true,"gnssid":0,"svid":7},{"PRN":8,"el":12,"az":175,"ss":15,"used":false,"gnssid":0,"svid":8},{"PRN":13,"el":8,"az":20,"ss":37,"used":true,"gnssid":0,"svid":13},{"PRN":15,"el":15,"az":51,"ss":29,"used":true,"gnssid":0,"svid":15},{"PRN":16,"el":49,"az":210,"ss":23,"used":true,"gnssid":0,"svid":16},{"PRN":18,"el":56,"az":102,"ss":27,"used":true,"gnssid":0,"svid":18},{"PRN":19,"el":38,"az":293,"ss":33,"used":true,"gnssid":0,"svid":19},{"PRN":20,"el":7,"az":40,"ss":18,"used":true,"gnssid":0,"svid":20},{"PRN":21,"el":36,"az":72,"ss":31,"used":true,"gnssid":0,"svid":21},{"PRN":22,"el":46,"az":164,"ss":26,"used":true,"gnssid":0,"svid":22},{"PRN":26,"el":25,"az":186,"ss":21,"used":true,"gnssid":0,"svid":26},{"PRN":27,"el":72,"az":289,"ss":19,"used":true,"gnssid":0,"svid":27},{"PRN":30,"el":8,"az":336,"ss":24,"used":false,"gnssid":0,"svid":30},{"PRN":69,"el":22,"az":29,"ss":34,"used":true,"gnssid":6,"svid":5},{"PRN":70,"el":52,"az":93,"ss":27,"used":true,"gnssid":6,"svid":6},{"PRN":71,"el":27,"az":157,"ss":25,"used":true,"gnssid":6,"svid":7},{"PRN":76,"el":25,"az":257,"ss":21,"used":true,"gnssid":6,"svid":12},{"PRN":77,"el":28,"az":318,"ss":33,"used":true,"gnssid":6,"svid":13},{"PRN":78,"el":3,"az":3,"ss":0,"used":false,"gnssid":6,"svid":14},{"PRN":84,"el":5,"az":98,"ss":12,"used":false,"gnssid":6,"svid":20},{"PRN":85,"el":51,"az":83,"ss":26,"used":true,"gnssid":6,"svid":21},{"PRN":86,"el":64,"az":319,"ss":44,"used":true,"gnssid":6,"svid":22},{"PRN":87,"el":12,"az":289,"ss":25,"used":true,"gnssid":6,"svid":23}]}

 $GNGLL,5230.88855,N,01327.85591,E,181141.00,A,A*70
-{"class":"TPV","mode":3,"time":"2015-06-19T18:11:41.000Z","ept":0.005,"lat":52.514809167,"lon":13.464265167,"alt":62.600,"epx":8.515,"epy":9.839,"epv":29.670,"track":0.0000,"speed":0.016,"climb":0.000}

+{"class":"TPV","mode":3,"time":"2015-06-19T18:11:41.000Z","ept":0.005,"lat":52.514809167,"lon":13.464265167,"alt":62.600,"epx":8.515,"epy":9.839,"epv":29.670,"track":0.0000,"speed":0.016}

 $GNGST,181141.00,46,,,,4.7,1.9,5.3*4A
 {"class":"GST","time":"2015-06-21T20:30:42.000Z","rms":46.000,"lat":4.700,"lon":1.900,"alt":5.300}

 $GNZDA,181141.00,19,06,2015,00,00*7C
@@ -40,7 +40,7 @@ $GNGST,181142.00,46,,,,4.7,1.9,5.3*49
 {"class":"GST","time":"2015-06-21T20:30:44.000Z","rms":46.000,"lat":4.700,"lon":1.900,"alt":5.300}

 $GNZDA,181142.00,19,06,2015,00,00*7F
 $GNGBS,181142.00,4.7,1.9,5.3,87,,-54900.3,57.3*45
-{"class":"TPV","mode":3,"time":"2015-06-19T18:11:42.000Z","ept":0.005,"lat":52.514809333,"lon":13.464264333,"alt":62.400,"epx":1.900,"epy":4.700,"epv":5.300,"track":0.0000,"speed":0.014,"climb":0.000,"eps":11.76}

+{"class":"TPV","mode":3,"time":"2015-06-19T18:11:42.000Z","ept":0.005,"lat":52.514809333,"lon":13.464264333,"alt":62.400,"epx":1.900,"epy":4.700,"epv":5.300,"track":0.0000,"speed":0.014,"climb":-0.200,"eps":11.76,"epc":34.97}

 $GNRMC,181143.00,A,5230.88858,N,01327.85582,E,0.011,,190615,,,A*6E
 $GNVTG,,T,,M,0.011,N,0.021,K,A*3E
 $GNGGA,181143.00,5230.88858,N,01327.85582,E,1,12,0.93,62.2,M,42.1,M,,*70
@@ -59,4 +59,4 @@ $GNGST,181143.00,45,,,,4.7,1.9,5.3*4B
 {"class":"GST","time":"2015-06-21T20:30:46.000Z","rms":45.000,"lat":4.700,"lon":1.900,"alt":5.300}

 $GNZDA,181143.00,19,06,2015,00,00*7E
 $GNGBS,181143.00,4.7,1.9,5.3,87,,-54898.6,57.2*40
-{"class":"TPV","mode":3,"time":"2015-06-19T18:11:43.000Z","ept":0.005,"lat":52.514809667,"lon":13.464263667,"alt":62.200,"epx":1.900,"epy":4.700,"epv":5.300,"track":0.0000,"speed":0.006,"climb":0.000,"eps":11.76}

+{"class":"TPV","mode":3,"time":"2015-06-19T18:11:43.000Z","ept":0.005,"lat":52.514809667,"lon":13.464263667,"alt":62.200,"epx":1.900,"epy":4.700,"epv":5.300,"track":0.0000,"speed":0.006,"climb":-0.200,"eps":11.76,"epc":34.97}