Change NMEA mode setting, thus major changes in gpsd_error_model().

The start of this overly large patch was to simply move the test
for MODE_2D/3D flipping, which only affect NMEA 183, back into
driver_nmea0813.c

But that was intertwined with how gpsd_error_model() computes
derived variables, which required major changes to how NMEA 183
mode_2D/3D are set.

This ultimatly led to major regression test results.  Almost all for
the better.

I tried to break it up, but moving from one paradigm to another
needed one big jump...

1 files changed, 3 insertions, 3 deletions

diff --git a/test/daemon/magellan315.log.chk b/test/daemon/magellan315.log.chk
index f9638418..8d420653 100644
--- a/test/daemon/magellan315.log.chk
+++ b/test/daemon/magellan315.log.chk
@@ -5,7 +5,7 @@ $GPGGA,120824.76,3908.8199,N,00023.0832,W,1,06,2.1,00176,M,,,,*39
 $GPRMC,120824.76,A,3908.8199,N,00023.0832,W,00.0,000.0,130305,01.,W*62
 {"class":"TPV","mode":3,"time":"2005-03-13T12:08:24.760Z","ept":0.005,"lat":39.146998333,"lon":-0.384720000,"alt":176.000,"track":0.0000,"speed":0.000}

 $GPGSA,A,3,19,15,03,18,22,11,,,,,,,3.5,2.1,2.7*34
-{"class":"TPV","mode":3,"time":"2005-03-13T12:08:24.760Z","ept":0.005,"lat":39.146998333,"lon":-0.384720000,"alt":176.000,"epv":62.100,"track":0.0000,"speed":0.000,"climb":0.000}

+{"class":"TPV","mode":3,"time":"2005-03-13T12:08:24.760Z","ept":0.005,"lat":39.146998333,"lon":-0.384720000,"alt":176.000,"epv":62.100,"track":0.0000,"speed":0.000}

 $GPGSV,3,1,12,19,77,349,45,03,68,117,41,22,39,052,52,11,35,274,56*7E
 $GPGSV,3,2,12,15,22,062,52,14,21,106,,16,10,171,,18,10,040,47*73
 $GPGSV,3,3,12,01,08,146,,20,04,211,,08,02,294,,28,02,328,*70
@@ -13,7 +13,7 @@ $GPGSV,3,3,12,01,08,146,,20,04,211,,08,02,294,,28,02,328,*70
 $GPGLL,3908.8200,N,00023.0832,W,120827.523,A*2C
 $GPGGA,120827.52,3908.8200,N,00023.0832,W,1,06,2.1,00176,M,,,,*3F
 $GPRMC,120827.52,A,3908.8200,N,00023.0832,W,00.0,000.0,130305,01.,W*64
-{"class":"TPV","mode":3,"time":"2005-03-13T12:08:27.520Z","ept":0.005,"lat":39.147000000,"lon":-0.384720000,"alt":176.000,"epx":13.523,"epy":36.714,"epv":62.100,"track":0.0000,"speed":0.000,"climb":0.000,"eps":26.58}

+{"class":"TPV","mode":3,"time":"2005-03-13T12:08:27.520Z","ept":0.005,"lat":39.147000000,"lon":-0.384720000,"alt":176.000,"epx":13.523,"epy":36.714,"epv":62.100,"track":0.0000,"speed":0.000,"climb":0.000,"eps":26.58,"epc":44.95}

 $GPGSA,A,3,19,15,03,18,22,11,,,,,,,3.5,2.1,2.7*34
 $GPGSV,3,1,12,19,77,349,46,03,68,117,42,22,39,052,50,11,35,274,55*7F
 $GPGSV,3,2,12,15,22,062,52,14,21,106,,16,10,171,,18,10,040,49*7D
@@ -22,7 +22,7 @@ $GPGSV,3,3,12,01,08,146,,20,04,211,,08,02,294,,28,02,328,*70
 $GPGLL,3908.8201,N,00023.0832,W,120829.500,A*22
 $GPGGA,120829.50,3908.8201,N,00023.0832,W,1,06,2.1,00176,M,,,,*32
 $GPRMC,120829.50,A,3908.8201,N,00023.0832,W,00.0,000.0,130305,01.,W*69
-{"class":"TPV","mode":3,"time":"2005-03-13T12:08:29.500Z","ept":0.005,"lat":39.147001667,"lon":-0.384720000,"alt":176.000,"epx":13.523,"epy":36.714,"epv":62.100,"track":0.0000,"speed":0.000,"climb":0.000,"eps":37.08}

+{"class":"TPV","mode":3,"time":"2005-03-13T12:08:29.500Z","ept":0.005,"lat":39.147001667,"lon":-0.384720000,"alt":176.000,"epx":13.523,"epy":36.714,"epv":62.100,"track":0.0000,"speed":0.000,"climb":0.000,"eps":37.08,"epc":62.73}

 $GPGSA,A,3,19,15,03,18,22,11,,,,,,,3.5,2.1,2.7*34
 $GPGSV,3,1,12,19,77,349,44,03,68,117,42,22,39,052,52,11,35,274,56*7C
 $GPGSV,3,2,12,15,22,062,52,14,21,106,,16,10,171,,18,10,040,47*73