Do *not* clear DOPs every time a satellite picture comes from the receiver.

Required a regression-test rebuild.

The immediate reason for this was Savannah bug bug #37810:
satellites_used always zero via gpsd socket with multi nmea GSA/GSV. As the
user reporting said:

The "satellites_used" field in a "struct gps_data_t" filled in by
"gps_read" is always returning zero.

This module emits GNGSA messages in a group of three. My information
is that the first GNGSA pertains to GPS, second to GLONASS, third to
QZSS. It also emits GSV messages using talker id's GL,GP,QZ.

The larger point is that DOPs are likely to be valid for longer than
a GSV reporting cycle; they change only slowly as the actual sat
configuration does.  So it makes sense to retain them.

1 files changed, 5 insertions, 5 deletions

diff --git a/test/daemon/magellan315.log.chk b/test/daemon/magellan315.log.chk
index ef0457c6..e532ad20 100644
--- a/test/daemon/magellan315.log.chk
+++ b/test/daemon/magellan315.log.chk
@@ -9,22 +9,22 @@ $GPGSA,A,3,19,15,03,18,22,11,,,,,,,3.5,2.1,2.7*34
 $GPGSV,3,1,12,19,77,349,45,03,68,117,41,22,39,052,52,11,35,274,56*7E
 $GPGSV,3,2,12,15,22,062,52,14,21,106,,16,10,171,,18,10,040,47*73
 $GPGSV,3,3,12,01,08,146,,20,04,211,,08,02,294,,28,02,328,*70
-{"class":"SKY","tag":"GSV","xdop":0.76,"ydop":1.47,"vdop":1.85,"tdop":1.37,"hdop":1.65,"gdop":2.83,"pdop":2.48,"satellites":[{"PRN":19,"el":77,"az":349,"ss":45,"used":true},{"PRN":3,"el":68,"az":117,"ss":41,"used":true},{"PRN":22,"el":39,"az":52,"ss":52,"used":true},{"PRN":11,"el":35,"az":274,"ss":56,"used":true},{"PRN":15,"el":22,"az":62,"ss":52,"used":true},{"PRN":14,"el":21,"az":106,"ss":0,"used":false},{"PRN":16,"el":10,"az":171,"ss":0,"used":false},{"PRN":18,"el":10,"az":40,"ss":47,"used":true},{"PRN":1,"el":8,"az":146,"ss":0,"used":false},{"PRN":20,"el":4,"az":211,"ss":0,"used":false},{"PRN":8,"el":2,"az":294,"ss":0,"used":false},{"PRN":28,"el":2,"az":328,"ss":0,"used":false}]}

+{"class":"SKY","tag":"GSV","xdop":0.76,"ydop":1.47,"vdop":2.70,"tdop":1.37,"hdop":2.10,"gdop":2.83,"pdop":3.50,"satellites":[{"PRN":19,"el":77,"az":349,"ss":45,"used":true},{"PRN":3,"el":68,"az":117,"ss":41,"used":true},{"PRN":22,"el":39,"az":52,"ss":52,"used":true},{"PRN":11,"el":35,"az":274,"ss":56,"used":true},{"PRN":15,"el":22,"az":62,"ss":52,"used":true},{"PRN":14,"el":21,"az":106,"ss":0,"used":false},{"PRN":16,"el":10,"az":171,"ss":0,"used":false},{"PRN":18,"el":10,"az":40,"ss":47,"used":true},{"PRN":1,"el":8,"az":146,"ss":0,"used":false},{"PRN":20,"el":4,"az":211,"ss":0,"used":false},{"PRN":8,"el":2,"az":294,"ss":0,"used":false},{"PRN":28,"el":2,"az":328,"ss":0,"used":false}]}

 $GPGLL,3908.8200,N,00023.0832,W,120827.523,A*2C
 $GPGGA,120827.52,3908.8200,N,00023.0832,W,1,06,2.1,00176,M,,,,*3F
 $GPRMC,120827.52,A,3908.8200,N,00023.0832,W,00.0,000.0,130305,01.,W*64
-{"class":"TPV","tag":"RMC","mode":3,"time":"2005-03-13T12:08:27.520Z","ept":0.005,"lat":39.147000000,"lon":-0.384720000,"alt":176.000,"epx":11.328,"epy":22.003,"epv":42.504,"track":0.0000,"speed":0.000,"climb":0.000,"eps":15.93}

+{"class":"TPV","tag":"RMC","mode":3,"time":"2005-03-13T12:08:27.520Z","ept":0.005,"lat":39.147000000,"lon":-0.384720000,"alt":176.000,"epx":11.328,"epy":22.003,"epv":62.100,"track":0.0000,"speed":0.000,"climb":0.000,"eps":15.93}

 $GPGSA,A,3,19,15,03,18,22,11,,,,,,,3.5,2.1,2.7*34
 $GPGSV,3,1,12,19,77,349,46,03,68,117,42,22,39,052,50,11,35,274,55*7F
 $GPGSV,3,2,12,15,22,062,52,14,21,106,,16,10,171,,18,10,040,49*7D
 $GPGSV,3,3,12,01,08,146,,20,04,211,,08,02,294,,28,02,328,*70
-{"class":"SKY","tag":"GSV","xdop":0.76,"ydop":1.47,"vdop":1.85,"tdop":1.37,"hdop":1.65,"gdop":2.83,"pdop":2.48,"satellites":[{"PRN":19,"el":77,"az":349,"ss":46,"used":true},{"PRN":3,"el":68,"az":117,"ss":42,"used":true},{"PRN":22,"el":39,"az":52,"ss":50,"used":true},{"PRN":11,"el":35,"az":274,"ss":55,"used":true},{"PRN":15,"el":22,"az":62,"ss":52,"used":true},{"PRN":14,"el":21,"az":106,"ss":0,"used":false},{"PRN":16,"el":10,"az":171,"ss":0,"used":false},{"PRN":18,"el":10,"az":40,"ss":49,"used":true},{"PRN":1,"el":8,"az":146,"ss":0,"used":false},{"PRN":20,"el":4,"az":211,"ss":0,"used":false},{"PRN":8,"el":2,"az":294,"ss":0,"used":false},{"PRN":28,"el":2,"az":328,"ss":0,"used":false}]}

+{"class":"SKY","tag":"GSV","xdop":0.76,"ydop":1.47,"vdop":2.70,"tdop":1.37,"hdop":2.10,"gdop":2.83,"pdop":3.50,"satellites":[{"PRN":19,"el":77,"az":349,"ss":46,"used":true},{"PRN":3,"el":68,"az":117,"ss":42,"used":true},{"PRN":22,"el":39,"az":52,"ss":50,"used":true},{"PRN":11,"el":35,"az":274,"ss":55,"used":true},{"PRN":15,"el":22,"az":62,"ss":52,"used":true},{"PRN":14,"el":21,"az":106,"ss":0,"used":false},{"PRN":16,"el":10,"az":171,"ss":0,"used":false},{"PRN":18,"el":10,"az":40,"ss":49,"used":true},{"PRN":1,"el":8,"az":146,"ss":0,"used":false},{"PRN":20,"el":4,"az":211,"ss":0,"used":false},{"PRN":8,"el":2,"az":294,"ss":0,"used":false},{"PRN":28,"el":2,"az":328,"ss":0,"used":false}]}

 $GPGLL,3908.8201,N,00023.0832,W,120829.500,A*22
 $GPGGA,120829.50,3908.8201,N,00023.0832,W,1,06,2.1,00176,M,,,,*32
 $GPRMC,120829.50,A,3908.8201,N,00023.0832,W,00.0,000.0,130305,01.,W*69
-{"class":"TPV","tag":"RMC","mode":3,"time":"2005-03-13T12:08:29.500Z","ept":0.005,"lat":39.147001667,"lon":-0.384720000,"alt":176.000,"epx":11.328,"epy":22.003,"epv":42.504,"track":0.0000,"speed":0.000,"climb":0.000,"eps":22.23}

+{"class":"TPV","tag":"RMC","mode":3,"time":"2005-03-13T12:08:29.500Z","ept":0.005,"lat":39.147001667,"lon":-0.384720000,"alt":176.000,"epx":11.328,"epy":22.003,"epv":62.100,"track":0.0000,"speed":0.000,"climb":0.000,"eps":22.23}

 $GPGSA,A,3,19,15,03,18,22,11,,,,,,,3.5,2.1,2.7*34
 $GPGSV,3,1,12,19,77,349,44,03,68,117,42,22,39,052,52,11,35,274,56*7C
 $GPGSV,3,2,12,15,22,062,52,14,21,106,,16,10,171,,18,10,040,47*73
 $GPGSV,3,3,12,01,08,146,,20,04,211,,08,02,294,,28,02,328,*70
-{"class":"SKY","tag":"GSV","xdop":0.76,"ydop":1.47,"vdop":1.85,"tdop":1.37,"hdop":1.65,"gdop":2.83,"pdop":2.48,"satellites":[{"PRN":19,"el":77,"az":349,"ss":44,"used":true},{"PRN":3,"el":68,"az":117,"ss":42,"used":true},{"PRN":22,"el":39,"az":52,"ss":52,"used":true},{"PRN":11,"el":35,"az":274,"ss":56,"used":true},{"PRN":15,"el":22,"az":62,"ss":52,"used":true},{"PRN":14,"el":21,"az":106,"ss":0,"used":false},{"PRN":16,"el":10,"az":171,"ss":0,"used":false},{"PRN":18,"el":10,"az":40,"ss":47,"used":true},{"PRN":1,"el":8,"az":146,"ss":0,"used":false},{"PRN":20,"el":4,"az":211,"ss":0,"used":false},{"PRN":8,"el":2,"az":294,"ss":0,"used":false},{"PRN":28,"el":2,"az":328,"ss":0,"used":false}]}

+{"class":"SKY","tag":"GSV","xdop":0.76,"ydop":1.47,"vdop":2.70,"tdop":1.37,"hdop":2.10,"gdop":2.83,"pdop":3.50,"satellites":[{"PRN":19,"el":77,"az":349,"ss":44,"used":true},{"PRN":3,"el":68,"az":117,"ss":42,"used":true},{"PRN":22,"el":39,"az":52,"ss":52,"used":true},{"PRN":11,"el":35,"az":274,"ss":56,"used":true},{"PRN":15,"el":22,"az":62,"ss":52,"used":true},{"PRN":14,"el":21,"az":106,"ss":0,"used":false},{"PRN":16,"el":10,"az":171,"ss":0,"used":false},{"PRN":18,"el":10,"az":40,"ss":47,"used":true},{"PRN":1,"el":8,"az":146,"ss":0,"used":false},{"PRN":20,"el":4,"az":211,"ss":0,"used":false},{"PRN":8,"el":2,"az":294,"ss":0,"used":false},{"PRN":28,"el":2,"az":328,"ss":0,"used":false}]}