Clear DOPs only when we get a skyview report.

This solves the disappearing epx/epy bug on SiRFs, but it was actually a
systemic problem that affected several drivers.  Navigation solution messages
were clearing DOPs, making it impossible for the error modeller to compute
estimates. New logic: Clear DOPs only when we get a skyview report.  They'll
be regenerated by our visibility-matrix calculation when the skyview sentence
is analyzed.

If a sentence from the device supplies a DOP between the time the visibility
calculation is done and when the next fix is reported, it will override
our computed value.  This might change later!

This change required a regression-test rebuild.

1 files changed, 7 insertions, 7 deletions

diff --git a/test/daemon/oncore.log.chk b/test/daemon/oncore.log.chk
index 80953c5e..18853e33 100644
--- a/test/daemon/oncore.log.chk
+++ b/test/daemon/oncore.log.chk
@@ -1,7 +1,7 @@
 $GPGSV,3,1,09,02,33,299,27,04,43,242,26,08,12,202,,13,85,356,*70
 $GPGSV,3,2,09,16,22,059,,20,21,131,,23,54,074,,24,23,195,*71
 $GPGSV,3,3,09,27,39,195,15,,,,,,,,,,,,*46
-{"class":"SKY","tag":"GSV","xdop":0.00,"ydop":0.00,"satellites":[{"PRN":2,"el":33,"az":299,"ss":27,"used":false},{"PRN":4,"el":43,"az":242,"ss":26,"used":false},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":356,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":39,"az":195,"ss":15,"used":false}]}

+{"class":"SKY","tag":"GSV","satellites":[{"PRN":2,"el":33,"az":299,"ss":27,"used":false},{"PRN":4,"el":43,"az":242,"ss":26,"used":false},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":356,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":39,"az":195,"ss":15,"used":false}]}

 $GPRMC,171244.00,A,5209.7838,N,02048.4818,E,0.6,71.0,080405,3.5,E*63
 {"class":"TPV","tag":"RMC","time":1112980364.000,"ept":0.005,"lat":52.163063333,"lon":20.808030000,"track":71.0000,"speed":0.309,"mode":2}

 $GPGGA,171245.00,5209.7838,N,02048.4819,E,1,03,5.3,76.6,M,36.5,M,,*5A
@@ -10,7 +10,7 @@ $GPGSA,A,2,02,04,27,,,,,,,,,,,5.3,*36
 $GPGSV,3,1,09,02,33,299,27,04,43,242,26,08,12,202,,13,85,356,*70
 $GPGSV,3,2,09,16,22,059,,20,21,131,,23,54,074,,24,23,195,*71
 $GPGSV,3,3,09,27,39,195,13,,,,,,,,,,,,*40
-{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":5.30,"pdop":0.00,"satellites":[{"PRN":2,"el":33,"az":299,"ss":27,"used":true},{"PRN":4,"el":43,"az":242,"ss":26,"used":true},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":356,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":39,"az":195,"ss":13,"used":true}]}

+{"class":"SKY","tag":"GSV","satellites":[{"PRN":2,"el":33,"az":299,"ss":27,"used":true},{"PRN":4,"el":43,"az":242,"ss":26,"used":true},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":356,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":39,"az":195,"ss":13,"used":true}]}

 $GPRMC,171245.00,A,5209.7838,N,02048.4819,E,0.3,41.9,080405,3.5,E*6C
 {"class":"TPV","tag":"RMC","time":1112980365.000,"ept":0.005,"lat":52.163063333,"lon":20.808031667,"alt":76.600,"epv":0.000,"track":41.9000,"speed":0.154,"climb":0.000,"mode":3}

 $GPGGA,171246.00,5209.7839,N,02048.4824,E,1,03,5.3,76.6,M,36.5,M,,*56
@@ -19,7 +19,7 @@ $GPGSA,A,2,02,04,27,,,,,,,,,,,5.3,*36
 $GPGSV,3,1,09,02,33,299,27,04,43,242,26,08,12,202,,13,85,356,*70
 $GPGSV,3,2,09,16,22,059,,20,21,131,,23,54,074,,24,23,195,*71
 $GPGSV,3,3,09,27,39,195,16,,,,,,,,,,,,*45
-{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":5.30,"pdop":0.00,"satellites":[{"PRN":2,"el":33,"az":299,"ss":27,"used":true},{"PRN":4,"el":43,"az":242,"ss":26,"used":true},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":356,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":39,"az":195,"ss":16,"used":true}]}

+{"class":"SKY","tag":"GSV","satellites":[{"PRN":2,"el":33,"az":299,"ss":27,"used":true},{"PRN":4,"el":43,"az":242,"ss":26,"used":true},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":356,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":39,"az":195,"ss":16,"used":true}]}

 $GPRMC,171246.00,A,5209.7839,N,02048.4824,E,0.5,75.4,080405,3.5,E*6C
 {"class":"TPV","tag":"RMC","time":1112980366.000,"ept":0.005,"lat":52.163065000,"lon":20.808040000,"alt":76.600,"epv":0.000,"track":75.4000,"speed":0.257,"climb":0.000,"mode":3}

 $GPGGA,171247.00,5209.7838,N,02048.4821,E,1,03,5.3,76.6,M,36.5,M,,*53
@@ -28,7 +28,7 @@ $GPGSA,A,2,02,04,27,,,,,,,,,,,5.3,*36
 $GPGSV,3,1,09,02,33,299,28,04,43,242,26,08,12,202,,13,85,357,*7E
 $GPGSV,3,2,09,16,22,059,,20,21,131,,23,54,074,,24,23,195,*71
 $GPGSV,3,3,09,27,40,195,15,,,,,,,,,,,,*48
-{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":5.30,"pdop":0.00,"satellites":[{"PRN":2,"el":33,"az":299,"ss":28,"used":true},{"PRN":4,"el":43,"az":242,"ss":26,"used":true},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":357,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":40,"az":195,"ss":15,"used":true}]}

+{"class":"SKY","tag":"GSV","satellites":[{"PRN":2,"el":33,"az":299,"ss":28,"used":true},{"PRN":4,"el":43,"az":242,"ss":26,"used":true},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":357,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":40,"az":195,"ss":15,"used":true}]}

 $GPRMC,171247.00,A,5209.7838,N,02048.4821,E,0.5,269.3,080405,3.5,E*51
 {"class":"TPV","tag":"RMC","time":1112980367.000,"ept":0.005,"lat":52.163063333,"lon":20.808035000,"alt":76.600,"epv":0.000,"track":269.3000,"speed":0.257,"climb":0.000,"mode":3}

 $GPGGA,171248.00,5209.7839,N,02048.4824,E,1,03,5.3,76.6,M,36.5,M,,*58
@@ -37,7 +37,7 @@ $GPGSA,A,2,02,04,27,,,,,,,,,,,5.3,*36
 $GPGSV,3,1,09,02,33,299,28,04,43,242,25,08,12,202,,13,85,357,*7D
 $GPGSV,3,2,09,16,22,059,,20,21,131,,23,54,074,,24,23,195,*71
 $GPGSV,3,3,09,27,40,195,15,,,,,,,,,,,,*48
-{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":5.30,"pdop":0.00,"satellites":[{"PRN":2,"el":33,"az":299,"ss":28,"used":true},{"PRN":4,"el":43,"az":242,"ss":25,"used":true},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":357,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":40,"az":195,"ss":15,"used":true}]}

+{"class":"SKY","tag":"GSV","satellites":[{"PRN":2,"el":33,"az":299,"ss":28,"used":true},{"PRN":4,"el":43,"az":242,"ss":25,"used":true},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":357,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":40,"az":195,"ss":15,"used":true}]}

 $GPRMC,171248.00,A,5209.7839,N,02048.4824,E,0.2,0.0,080405,3.5,E*53
 {"class":"TPV","tag":"RMC","time":1112980368.000,"ept":0.005,"lat":52.163065000,"lon":20.808040000,"alt":76.600,"epv":0.000,"track":0.0000,"speed":0.103,"climb":0.000,"mode":3}

 $GPGGA,171249.00,5209.7839,N,02048.4827,E,1,03,5.3,76.6,M,36.5,M,,*5A
@@ -46,7 +46,7 @@ $GPGSA,A,2,02,04,27,,,,,,,,,,,5.3,*36
 $GPGSV,3,1,09,02,33,299,27,04,43,242,26,08,12,202,,13,85,357,*71
 $GPGSV,3,2,09,16,22,059,,20,21,131,,23,54,074,,24,23,195,*71
 $GPGSV,3,3,09,27,40,195,15,,,,,,,,,,,,*48
-{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":5.30,"pdop":0.00,"satellites":[{"PRN":2,"el":33,"az":299,"ss":27,"used":true},{"PRN":4,"el":43,"az":242,"ss":26,"used":true},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":357,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":40,"az":195,"ss":15,"used":true}]}

+{"class":"SKY","tag":"GSV","satellites":[{"PRN":2,"el":33,"az":299,"ss":27,"used":true},{"PRN":4,"el":43,"az":242,"ss":26,"used":true},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":357,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":40,"az":195,"ss":15,"used":true}]}

 $GPRMC,171249.00,A,5209.7839,N,02048.4827,E,0.3,80.9,080405,3.5,E*61
 {"class":"TPV","tag":"RMC","time":1112980369.000,"ept":0.005,"lat":52.163065000,"lon":20.808045000,"alt":76.600,"epv":0.000,"track":80.9000,"speed":0.154,"climb":0.000,"mode":3}

 $GPGGA,171250.00,5209.7839,N,02048.4829,E,1,03,5.3,76.6,M,36.5,M,,*5C
@@ -55,6 +55,6 @@ $GPGSA,A,2,02,04,27,,,,,,,,,,,5.3,*36
 $GPGSV,3,1,09,02,33,299,28,04,43,242,26,08,12,202,,13,85,357,*7E
 $GPGSV,3,2,09,16,22,059,,20,21,131,,23,54,074,,24,23,195,*71
 $GPGSV,3,3,09,27,40,195,15,,,,,,,,,,,,*48
-{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":5.30,"pdop":0.00,"satellites":[{"PRN":2,"el":33,"az":299,"ss":28,"used":true},{"PRN":4,"el":43,"az":242,"ss":26,"used":true},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":357,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":40,"az":195,"ss":15,"used":true}]}

+{"class":"SKY","tag":"GSV","satellites":[{"PRN":2,"el":33,"az":299,"ss":28,"used":true},{"PRN":4,"el":43,"az":242,"ss":26,"used":true},{"PRN":8,"el":12,"az":202,"ss":0,"used":false},{"PRN":13,"el":85,"az":357,"ss":0,"used":false},{"PRN":16,"el":22,"az":59,"ss":0,"used":false},{"PRN":20,"el":21,"az":131,"ss":0,"used":false},{"PRN":23,"el":54,"az":74,"ss":0,"used":false},{"PRN":24,"el":23,"az":195,"ss":0,"used":false},{"PRN":27,"el":40,"az":195,"ss":15,"used":true}]}

 $GPRMC,171250.00,A,5209.7839,N,02048.4829,E,0.3,77.8,080405,3.5,E*6E
 {"class":"TPV","tag":"RMC","time":1112980370.000,"ept":0.005,"lat":52.163065000,"lon":20.808048333,"alt":76.600,"epv":0.000,"track":77.8000,"speed":0.154,"climb":0.000,"mode":3}