Retire splint from our set of static analyzers.

The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches!  A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.

But this has been coming for a while.  Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained  and somewhat
buggy and not easy to use.

Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.

All regression tests pass. PPS observed live on GR601-W.

1 files changed, 3 insertions, 5 deletions

diff --git a/timebase.c b/timebase.c
index c44ed372..cddd5915 100644
--- a/timebase.c
+++ b/timebase.c
@@ -205,9 +205,7 @@ void gpsd_time_init(struct gps_context_t *context, time_t starttime)
      * the timezone offset).  Avoid this and all manner of other local
      * time issues by telling the system we want times returned in UTC.
      */
-    /*@-observertrans@*/
     (void)putenv("TZ=UTC");
-    /*@+observertrans@*/
 
     /*
      * Provides a start time for getting the century.  Do this, just
@@ -262,7 +260,7 @@ void gpsd_set_century(struct gps_device_t *session)
 }
 
 #ifdef NMEA_ENABLE
-timestamp_t gpsd_utc_resolve(/*@in@*/struct gps_device_t *session)
+timestamp_t gpsd_utc_resolve(struct gps_device_t *session)
 /* resolve a UTC date, checking for rollovers */
 {
     /*
@@ -299,7 +297,7 @@ timestamp_t gpsd_utc_resolve(/*@in@*/struct gps_device_t *session)
     return t;
 }
 
-void gpsd_century_update(/*@in@*/struct gps_device_t *session, int century)
+void gpsd_century_update(struct gps_device_t *session, int century)
 {
     session->context->valid |= CENTURY_VALID;
     if (century > session->context->century) {
@@ -325,7 +323,7 @@ void gpsd_century_update(/*@in@*/struct gps_device_t *session, int century)
 }
 #endif /* NMEA_ENABLE */
 
-timestamp_t gpsd_gpstime_resolve(/*@in@*/struct gps_device_t *session,
+timestamp_t gpsd_gpstime_resolve(struct gps_device_t *session,
 			 unsigned short week, double tow)
 {
     timestamp_t t;