summaryrefslogtreecommitdiff
path: root/xgps
diff options
context:
space:
mode:
authorFred Wright <fw@fwright.net>2017-01-19 17:49:59 -0800
committerFred Wright <fw@fwright.net>2017-01-19 18:19:27 -0800
commite91f750c1e9ac1e1340181febf89201cb3cce8bd (patch)
treeb32fb93625942b67d727d8cf6463b6792dc2b8d2 /xgps
parent4dd216c55d2838f71a1c7e445a2f180393e04fb3 (diff)
downloadgpsd-e91f750c1e9ac1e1340181febf89201cb3cce8bd.tar.gz
Fixes some trouble with gpsmon and no PPS_ENABLE.
Until recently, PPS_ENABLE was always true by default, even on platforms where it was intended to be forced off. Fixing this exposed some issues in gpsmon. This generally related to confusion between *displaying* PPS info versus *capturing* it. Since gpsmon can be run against a remote target, it should be able to report PPS info even when running on a host that doesn't support PPS, but the code was conflating the two issues. The changes here are: 1) There is now a PPS_DISPLAY_ENABLE, which is always true, and should be used in place of PPS_ENABLE in code related to displaying PPS info, to the extent possible. 2) The code related to processing remote TOFF and PPS events now uses this new conditional. Aside from restoring the presence of the "PPS offset" lines in the scrolling data, this also fixes a problem where the display malfunctioned when this code was absent. The exact nature of this dependency hasn't yet been determined, but there's a FIXME to document the issue. 3) The reporting of PPS offsets in the windowed area still doesn't work without PPS_ENABLE, due to the entanglement between that code and the pps_thread code. There are now a couple of FIXMEs related to that issue, which is being left for future work. 4) A couple of unnecessary PPS_ENABLE conditionals were eliminated by making use of the existing conditionally-defined lock/unlock functions. TESTED: Ran gpsmon on OSX 10.9 (where PPS_ENABLE is off) against three receivers (one local and two remote), with the expected results. Also ran it on Ubuntu 14 (where PPS_ENABLE is on) against the same three receivers (again one local and two remote), again with the expected results.
Diffstat (limited to 'xgps')
0 files changed, 0 insertions, 0 deletions