summaryrefslogtreecommitdiff
path: root/driver_navcom.c
Commit message (Collapse)AuthorAgeFilesLines
* driver_navcom: Remove unused variable.Gary E. Miller2019-03-271-1/+1
|
* driver_navcom: Move error math to gpsd_error_model()Gary E. Miller2019-03-261-16/+5
| | | | The numbers look better now.
* VERR_SET: Removed flag from daemon. No regressions changed.Gary E. Miller2019-03-251-2/+2
| | | | Obviously redundant.
* Split epe into eph and sep.Gary E. Miller2019-03-221-3/+3
| | | | | | | | Try to do it with forward and backward compatibility, which is challenging with current miscojson. Sometimes epe was used to 2D estimated erro. Sometimes for 3D error. So make it explicit eph is 2D, and sep is 3D.
* Move epe from gps_data_t to be near its friends in gps_fix_t.Gary E. Miller2019-03-151-2/+2
| | | | No functional changes. Looks like epe never went anywhere...
* LICENSE: Update licenses for consistency. No functional changes.Gary E. Miller2018-11-191-1/+1
|
* driver_navcom: note that ept seems incorrectly calculatedGary E. Miller2018-09-251-2/+3
|
* driver_navcom: fix cppcheck nit.Gary E. Miller2018-09-251-3/+2
|
* SPDXify the licerse references.Eric S. Raymond2018-03-081-1/+1
|
* uint was rmoved in C99. If gpsd enforce C99, then uint must go.Gary E. Miller2016-08-151-1/+1
| | | | uint is now unsigned int.
* PPSTIME -> NTPTIMEGary E. Miller2016-04-241-1/+1
| | | | | NTPTIME is from the serial stream, it never had anything to do with PPS and it just confused everyone.
* Add Coverity suppressions for new invariant checks.Eric S. Raymond2016-01-291-0/+3
|
* Address Savannah bug #46082 - Can't explicitly build with NMEA drivers.Eric S. Raymond2015-10-011-2/+2
|
* A drowning deluge of whitespace hacks.Gary E. Miller2015-04-301-3/+3
|
* Retire splint from our set of static analyzers.Eric S. Raymond2015-03-301-41/+0
| | | | | | | | | | | | | | | | | | | The proximate cause was that we've been seing emission of error messages that were randomly and disturbingly variable across different environments - notably Raspbian and Gentoo splint gave nontrivially different results than Ubuntu 14.10 splint. And this was *not* due to Ubuntu patches! A pristine splint built from the 3.1.2 tarball on Ubuntu didn't match the Raspbian and Gentoo results either. But this has been coming for a while. Easy access to more modern static analyzers such as coverity, scan-build and cppcheck has been decreasing the utility of splint, which is unmaintained and somewhat buggy and not easy to use. Only file not cleaned is ppsthread.c, because Gary has been working on it during this cleanup. All regression tests pass. PPS observed live on GR601-W.
* Fix more splint: Line expects to suppress X errors, found 0 errorsGary E. Miller2015-03-251-1/+1
|
* Fix cppcheck complaints about not enough parenthesis.Gary E. Miller2015-03-091-16/+16
| | | | | | | Change this: A & B ? 0 : 1 To this: (A & B) ? 0 : 1 No logic or functional change.
* One of the float-elimination steps busted something. Revert.Eric S. Raymond2015-03-081-3/+3
|
* A step toards float elimination. No code changes.Eric S. Raymond2015-03-081-3/+3
|
* gpsd-report() -> gpsd_log()Eric S. Raymond2015-03-071-202/+204
| | | | | | | | | | | | | | | | This change is done so we can add a "log" hook to the pps_thread_t structure (this is not done yet) and harmonize with the name of the outer logging function. If that name had been left as gpsd_report() there would have been scope for bad confusion with the report_hook member. Also, remove two stray duplicative printf calls from the NMEA2000 driver (drivers shouldn't have printfs!) and fix one typo. This is a step towards factoring out ntplib. For that to happen, the PPS thread code needs to be decoupled from the core session structure. No logic changes. Object compatibility preserved. All regression tests pass.
* Back out the attempt to use VTIME.Eric S. Raymond2015-01-311-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | According to Matthias Drochner at http://lists.lysator.liu.se/pipermail/lsh-bugs/2003q4/000151.html: I thought I'd give lsh a try, just to see how it compares to openssh... The client didn't work well on NetBSD, got a message like "unexpected EWOULDBLOCK" on each keystroke. Looked a bit deeper and found that stdin is set to O_NONBLOCK and a raw tty mode with c_cc[VMIN] > 1 and c_cc[VTIME] > 0. I'll append a little test program which does the same. I've tried it on 3 operating systems (Linux, NetBSD, Digital UNIX), and it behaves differently on each: -on Linux, if a key is pressed, the read returns immediately with that one character -on NetBSD, the read returns with no data but EWOULDBLOCK -on D'UNIX, the poll() doesn't teturn before 4 keypresses are done; the read() returns these 4 characters Indeed, in SUSv2's termios page is a sentence which says that if both O_NONBLOCK and VTIME>0 are set, the behaviour is more or less undefined. I've solved my immediate problems by setting VMIN to 1 instead of 4 in unix_interact.c:do_make_raw(), but VTIME is still pointless, so I wouldn't call this a clean solution. All regression tests pass.
* Add a minimum packet length to every driver.Eric S. Raymond2015-01-291-0/+1
| | | | Length 0 means the minimum is unknown and the driver should use character I/O.
* cppcheck cleanup.Eric S. Raymond2015-01-221-2/+2
|
* Coverity/splint cleanup.Eric S. Raymond2015-01-211-2/+2
| | | | | Turned up a bug in where a counter was incremented un the Navcom driver; this required one test rebuild.
* Easy splint cleanups. All regression tests pass.Eric S. Raymond2015-01-211-4/+4
|
* Almost entirely eliminate use of sats_used array.Eric S. Raymond2015-01-101-2/+2
| | | | | | | Instead, set the used member in the satellites array directly where possible. The NMEA0183 and TSIP drivers still need a local equivalent. This changes pseudo-NMEA GSA output in several binary-protocol tests.
* The particular Navcom binary protocol we support is called NCT.Eric S. Raymond2015-01-101-3/+3
| | | | All regression tests pass.
* In the navcom driver, get satellites used from the Channel Status packet.Eric S. Raymond2015-01-101-18/+13
| | | | | | Affects only GSA emission in pseudo-NMEA mode, fixing a lingering bug whee the last sat in the listing was sometimes duplicated. Required one test build.
* Improved internal documentation in the navcom driver.Eric S. Raymond2015-01-101-3/+19
| | | | All regressiomn tests pass.
* Rename for clarity.Eric S. Raymond2015-01-101-5/+5
|
* Refactor representation of satellite data into an array of structs...Eric S. Raymond2014-09-221-5/+5
| | | | | | | | | | | | | | | | | | ...from a set of parallel arrays. This change flushed out a longstanding bug in the computation of DOPs for estimated error bars. Some test-load rebuilds were required: geostar-geos1m-binary.log.chk: With this change error estimates are computed and reported. trimble-lassen_iq-3dfix.log, trimble-lassen_iq-3dfix.log: the change revealed a bug in the computation of satellite-seen bits. Error estimates did not change. navcom.log: Error estimates changed. With these rebuilds, all regression tests pass.
* Now that the transition is done we can restore the gpsd_report name.Eric S. Raymond2014-08-271-52/+52
| | | | All regression tests pass.
* The big leap. Most instances of gpsd_report are replaced...Eric S. Raymond2014-08-271-52/+52
| | | | | | | | | | | | | | | | ...with calls to gps_notify(), which indirects to its output method through a slot in an errout structure. Usually the errout structure lives inside the session context, but because struct errout_t is its own thing this does not have to be the case. One large clique of gpsd_notify() calls, in packet.c and isgps.c, looks at a struct errout_t copy in a lexer control block This change is not complete. Remnant gpsd_report calls need to be changed, and gpsmon needs to be tweaked so that the struct_error_t in its context is a non-defaukt hook updating the cuses display rather than simply dumping to stderr. Also the report label functionality needs to be added. All regression tests pass.
* Introduce struct errout_t to encapsulate error-reporting hooks.Eric S. Raymond2014-08-271-52/+52
| | | | | | A major step towards eliminating reverse linkage. All regression tests pass.
* Structure member name change: packet -> lexer. No logic changes.Eric S. Raymond2014-08-271-15/+15
| | | | All regression tests pass.
* Split firmwqre version query out of the init method.Eric S. Raymond2014-08-251-0/+1
| | | | | | This enables us to force readonly off while it's being called. The practical effect is that gpsmon can get a firmware version (if this is possible) without reconfiguring the device.
* Drop the obsolete tag field from JSON output. Bump the minor protocol number.Eric S. Raymond2014-08-241-3/+0
| | | | | | | Required a regression-test rebuild, of course. The field is still set by the TSIP and SiRF drivers; the SiRF driver actually uses it. It may be possible to eliminate the TSIP uses, but so far attempting this has produced odd regression-test failures.
* Reduce gpsd log verbosity a lot.Eric S. Raymond2013-11-121-33/+35
| | | | | | | | | | Way too much logging was happening at LOG_IO level, which is intended for watching data traffic in and out of the daemon rather than all the minutiae of data analysis - that's LOG_DATA. Also, LOG_DATA gets pushed down two levels. The effect is that -D 5 means exactly what it did, but for purposes other than driver debugging -D 4 now suffices.
* Rename and rationalize driver table instances. No logic changes.Eric S. Raymond2013-11-121-2/+2
|
* Contain the assumption that time hinting is done to NTPD.Eric S. Raymond2013-10-311-3/+3
| | | | | | | Because it might be going to chrony. Or something else. No logic changes, just name changes and one new derived #define, TIMEHINT_ENABLE.
* Revert "Separate ntpd support from chrony support, step 1."Eric S. Raymond2013-10-301-3/+3
| | | | We'll have to sneak up on this change more slowly.
* Separate ntpd support from chrony support, step 1.Eric S. Raymond2013-10-301-3/+3
| | | | | | | | | | | | | ntp_offset becomes time_offset. There is a new config symbol CHRONY_ENABLE; most time service code is npw controlled by TIMESERVICE_ENABLE. The file ntpshm.c becomes timeexport.c This change is not complete. More disentanglement has to be done inside timeexport.c itself; at the moment enabling one but not both of ntpshm or chrony will probably break its compile. The point of getting this commit out is so Gary will see the new baseline code ASAP. All regression tests pass.
* More efficiebt sticky-flagging.Eric S. Raymond2013-10-151-1/+1
|
* OK, visualize as a method was a bad idea. All regression tests pass.Eric S. Raymond2013-10-141-3/+0
|
* Create driver slot and scons option for a visualizer driver method.Eric S. Raymond2013-10-131-0/+3
|
* Change the logic for managing the drive mode bit to report reality...Eric S. Raymond2013-10-041-8/+2
| | | | ...rather than setting it ad-hoc on a per-driver basis.
* Change gpsd_report to no longer use a global. All regression tests pass.Eric S. Raymond2013-09-291-52/+56
| | | | | | | | This is a large, ugly change. But without it we can't troubleshoot the ICP/IP-source initialization bug properly - colliding definitions of gpsd_report() were interfering with error reporting early in gpsd runs. More cleanup work remains to be done, but at least this is working.
* Nuke trailing whitespace in C source.Eric S. Raymond2012-09-071-1/+1
|
* Refacter the bits.c stuff to eliminate ugly globals...Eric S. Raymond2012-06-021-14/+11
| | | | | | ...and be more explicit about operand sizes. All regressuion tests [ass, code splints clean.
* More cppcheck warning fixups. All regression tests pass.Eric S. Raymond2012-05-181-1/+2
|
View Lorry Controller Status