| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
At one point, the check for MODE_SET made sense in
gpsd_binary_quality_dump(). But since then, the calling code was
refactored to only invoke nmea_tpv_dump() when REPORT_IS is set,
eliminating the dupes.
Remove the MODE_SET check and update the affected binary regression
check files to contain the expected GSA sentences.
Signed-off-by: Gary E. Miller <gem@rellim.com>
|
|
|
|
| |
Thanks to Virgin Orbit for their support on this patch.
|
| |
|
|
|
|
|
|
|
|
| |
GPGSA is commonly taken to be 12 sats. Prevent ublox and TSIP drivers
from outputting more. No regressions had more than 12 anyway.
DOPs that were NaNs were output as 0.0. Now output as blanks.
Too easy for a user to take 0.0 as a real number.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches! A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.
But this has been coming for a while. Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained and somewhat
buggy and not easy to use.
Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.
All regression tests pass. PPS observed live on GR601-W.
|
| |
|
| |
|
|
|
|
| |
This change doesn't affect generated binary code.
|
| |
|
|
|
|
|
|
|
| |
Instead, set the used member in the satellites array directly where possible.
The NMEA0183 and TSIP drivers still need a local equivalent.
This changes pseudo-NMEA GSA output in several binary-protocol tests.
|
|
|
|
| |
Change if 1 to ifdef NEMA_ENABLED for which variant of sats used
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...from a set of parallel arrays. This change flushed out a
longstanding bug in the computation of DOPs for estimated error bars.
Some test-load rebuilds were required:
geostar-geos1m-binary.log.chk: With this change error
estimates are computed and reported.
trimble-lassen_iq-3dfix.log, trimble-lassen_iq-3dfix.log: the
change revealed a bug in the computation of satellite-seen bits.
Error estimates did not change.
navcom.log: Error estimates changed.
With these rebuilds, all regression tests pass.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Um. What was I thinking when I wrote that guard? It zeroed out
reports of satellites used.
Required a rebuild of the following (binary-orotocol) test logs.
test/daemon/bu303-climbing.log.chk
test/daemon/bu303-moving.log.chk
test/daemon/bu303-stillfix.log.chk
test/daemon/italk-binary.log.chk
test/daemon/navcom.log.chk
test/daemon/superstar2.log.chk
test/daemon/trimble-lassen_iq-3dfix.log.chk
test/daemon/trimble-lassen_iq.log.chk
test/daemon/ublox-aek-4t.log.chk
test/daemon/ublox-lea-4t.log.chk
test/daemon/ublox-sirf1.log.chk
test/daemon/zodiac.log.chk
After that, all regressiion tests pass.
|
|
|
|
| |
All regression tests pass.
|
|
|
|
|
|
| |
This allows us to get ride of the AIVDM event hook, because it all
tthat was doing was zeroing a queue index that will now be zeroed
at the time of the device structure initialization.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Required so clients looking at flag masks in data exported via the shared-memory
interface will see the right thing.
These were separated originally in order to avoid pushing the reqyuired width
of the gpsdata.set flag mask over 32 bits. It became 64 bits in the Version 5
API change, so that constraint went away.
All regression tests pass.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Enables gpsd to link with uClibc. Addresses Berlios tracker bug #17368.
|
| |
|
| |
|
| |
|
|
|
|
| |
All regression tests pass.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Large patch, no actual executable code changes except in three debug dumpers.
Breaks up the *_SET status macros so the client side continues to use them,
but the daemon uses a similarly-named set with an _IS suffix.
This frees up two mask bits in both sets - the client side no longer needs
to have REPORT_SET and CLEAR_SET bits, and the daemon side no longer needs
to have VERSION_SET and POLICY_SET.
The only actual code change is that the maskdump.c module, generated by
maskaudit.py, splits in half - one child now dumps client-side flags, the
other daemon-side flags. One other function call in a debug dumper in
libgps_core.c changes.
All regression tests pass.
|
| |
|
| |
|
|
|
|
| |
All regression tests pass,
|
|
|
|
|
|
|
|
|
| |
ERR_SET is now gone entirely, so in the extremely unlikely even that
an app developer got caught by this (could never happen unless they
shipped a bad command via the deprecated gps_send() entry point) the
code will break noisily.
All regression tests pass.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix it by adding a json switch separate from watch enable. This
involved moving where fake NMEA is generated to a different place,
treating it as just another form of report generation rather than a
side effect of receiving a sentence. Also, some client-side code had
to be changed to use the json flag.
A side effect is that some binary-protocol devicers generate fake $GPGSA
sentences somewhat more often than they used to, and this meant rebuilding
four more regression tests.
|
|
|
|
|
|
|
| |
That is, instead of sectioning out two little config defines and
putting them in. This makes gpsd.h self-copntained (e.g. in case it
gets installed as a library header) and means we can get rid of most
inclusions of it.
|
|
|
|
| |
All regression tests pass, code splints clean.
|
|
|
|
|
| |
...when multiple channels are active. Codebase splints clean, all
regression tests pass
|
| |
|
|
|
|
|
|
| |
...from the internals of gpsd. Besides being better factoring, this
will give us better control of the daemon's report-generation policy
in the future. All regression tests pass. Codebase splints clean.
|