| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
The gpsd exports data to clients via shared-memory using
struct shmexport_t, which contains both a copy of
struct gps_data_t and additional fields. However, when
allocating shared memory via shmget(), it was passing
sizeof(struct gps_data_t) as size of the whole segment.
The bug may cause gpsd crash in case the size of gps_data_t
is equal to or slightly smaller than a multiple of PAGE_SIZE.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches! A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.
But this has been coming for a while. Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained and somewhat
buggy and not easy to use.
Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.
All regression tests pass. PPS observed live on GR601-W.
|
|
|
|
|
|
| |
gpsd_config.h needs time_t which is in time.h
OS X builds now. Untested.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is done so we can add a "log" hook to the pps_thread_t
structure (this is not done yet) and harmonize with the name of the
outer logging function. If that name had been left as gpsd_report()
there would have been scope for bad confusion with the report_hook
member.
Also, remove two stray duplicative printf calls from the NMEA2000 driver
(drivers shouldn't have printfs!) and fix one typo.
This is a step towards factoring out ntplib. For that to happen, the
PPS thread code needs to be decoupled from the core session structure.
No logic changes. Object compatibility preserved. All regression tests pass.
|
|
|
|
|
|
| |
Also, ensure this always happens within the regression-test driver.
All regression tests pass.
|
|
|
|
| |
All regression tests pass. No logic changes.
|
|
|
|
| |
All regression tests pass.
|
| |
|
| |
|
|
|
|
|
|
|
| |
All regression tests pass with both gcc- and clang-built binaries.
One clang warning remains in the JSON test code.
|
|
|
|
| |
All regression tests pass.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...with calls to gps_notify(), which indirects to its output method
through a slot in an errout structure. Usually the errout structure
lives inside the session context, but because struct errout_t is its
own thing this does not have to be the case. One large clique of
gpsd_notify() calls, in packet.c and isgps.c, looks at a struct
errout_t copy in a lexer control block
This change is not complete. Remnant gpsd_report calls need to be changed,
and gpsmon needs to be tweaked so that the struct_error_t in its context
is a non-defaukt hook updating the cuses display rather than simply
dumping to stderr. Also the report label functionality needs to be added.
All regression tests pass.
|
|
|
|
|
|
| |
A major step towards eliminating reverse linkage.
All regression tests pass.
|
|
|
|
|
|
|
|
|
| |
Also, fix how configuratuin in libgps_shm.c and smexport.h is handled.
Based on a patch by Samuel Cuella <samuel.cuella@supinfo.com>, but cleaned
up some to obey local conventions better.
All regression tests pass.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This is a large, ugly change. But without it we can't troubleshoot the
ICP/IP-source initialization bug properly - colliding definitions of
gpsd_report() were interfering with error reporting early in gpsd runs.
More cleanup work remains to be done, but at least this is working.
|
| |
|
|
|
|
| |
Timeout argument is presently ignored.
|
| |
|
| |
|
| |
|
|
|
|
| |
All regression tests pass. Code splints clean. shm live-testing works.
|
|
|
|
|
|
| |
This allows adding other compilers and/or architectures later as needed.
Signed-off-by: Eric S. Raymond <esr@thyrsus.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Required so clients looking at flag masks in data exported via the shared-memory
interface will see the right thing.
These were separated originally in order to avoid pushing the reqyuired width
of the gpsdata.set flag mask over 32 bits. It became 64 bits in the Version 5
API change, so that constraint went away.
All regression tests pass.
|
| |
|
|
|
|
| |
All regression tests pass, *with* shm export configured on.
|
|
Not configured in by default yet because it produces a strange regression
failure.
|