diff options
| author | Tim-Philipp Müller <tim@centricular.com> | 2019-02-26 00:00:33 +0000 |
|---|---|---|
| committer | Tim-Philipp Müller <tim@centricular.com> | 2019-03-04 11:54:15 +0000 |
| commit | ef8a1bdd90daa04e9022561a8c338f1a23ee4bdc (patch) | |
| tree | 44637916633bc788231fd98067dcfe1f29b01e95 /ext/libav/gstavauddec.h | |
| parent | caf953bd5d6128c8fce322d0590a513f3d2e412f (diff) | |
| download | gst-libav-ef8a1bdd90daa04e9022561a8c338f1a23ee4bdc.tar.gz | |
avauddec: fix decoding of APE and Cook audio
.. and other formats where ffmpeg gives us multiple
subframes per input frame.
Since we now support non-interleaved audio, we can't
just concat buffers any more. Also, audio metas won't
be combined when buffers are merged, so when we push
out the combined buffer we'll look at the meta describing
only the first subframe and think it covers the whole
frame leading to stutter/gaps in the output.
We could fix this by copying the output data into a new
buffer when we merge buffers, but that's suboptimal, so
let's add some API to GstAudioDecoder to push out subframes
and use that instead.
https://gitlab.freedesktop.org/gstreamer/gst-libav/issues/49
Diffstat (limited to 'ext/libav/gstavauddec.h')
| -rw-r--r-- | ext/libav/gstavauddec.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/ext/libav/gstavauddec.h b/ext/libav/gstavauddec.h index 1a194ab..d91de0d 100644 --- a/ext/libav/gstavauddec.h +++ b/ext/libav/gstavauddec.h @@ -44,9 +44,6 @@ struct _GstFFMpegAudDec /* prevent reopening the decoder on GST_EVENT_CAPS when caps are same as last time. */ GstCaps *last_caps; - /* Stores current buffers to push as GstAudioDecoder wants 1:1 mapping for input/output buffers */ - GstBuffer *outbuf; - /* current output format */ GstAudioInfo info; GstAudioChannelPosition ffmpeg_layout[64]; |