summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVíctor Manuel Jáquez Leal <vjaquez@igalia.com>2021-07-17 20:49:15 +0200
committerVíctor Manuel Jáquez Leal <vjaquez@igalia.com>2021-07-17 20:53:32 +0200
commitde19e8a84fb2fed99b14ab5310053bf6cdf24818 (patch)
treebde5392192b9d55388f38dcb77fac672aaa753c8
parentb45754b4781f994358fe3761b37f97dadb65b7a7 (diff)
downloadgstreamer-plugins-bad-de19e8a84fb2fed99b14ab5310053bf6cdf24818.tar.gz
va: vp9dec: Minor cleanups.
Added a comment with a future to-do, enhanced another comment and fixed a typo in an error log message. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2417>
-rw-r--r--sys/va/gstvavp9dec.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/sys/va/gstvavp9dec.c b/sys/va/gstvavp9dec.c
index 0340e1e4d..33631a84f 100644
--- a/sys/va/gstvavp9dec.c
+++ b/sys/va/gstvavp9dec.c
@@ -200,9 +200,13 @@ _check_resolution_change (GstVaVp9Dec * self, GstVp9Picture * picture)
self->need_negotiation = TRUE;
if (!gst_video_decoder_negotiate (GST_VIDEO_DECODER (self))) {
- GST_ERROR_OBJECT (self, "Resolution changes, but failed to"
+ GST_ERROR_OBJECT (self, "Resolution changed, but failed to"
" negotiate with downstream");
return FALSE;
+
+ /* @TODO: if negotiation fails, decoder should resize output
+ * frame. For that we would need an auxiliar allocator, and
+ * later use GstVaFilter or GstVideoConverter. */
}
}
@@ -544,9 +548,9 @@ gst_va_vp9_dec_negotiate (GstVideoDecoder * decoder)
self->need_negotiation = FALSE;
need_open = TRUE;
- /* The driver for VP9 should have the ability to handle the dynamical
- resolution changes. So if only the resolution changes, we should not
- re-create the config and context. */
+ /* VP9 profile entry should have the ability to handle dynamical
+ * resolution changes. If only the resolution changes, we should not
+ * re-create the config and context. */
if (gst_va_decoder_is_open (base->decoder)) {
VAProfile cur_profile;
guint cur_rtformat;