diff options
author | Sam Hurst <Sam.Hurst@bbc.co.uk> | 2017-08-07 16:41:27 +0100 |
---|---|---|
committer | Philippe Normand <philn@igalia.com> | 2017-08-08 09:06:49 +0100 |
commit | 6baa66a889624abc15813719d19ec39c68958df7 (patch) | |
tree | b7f5abcb6755947d5c9a4ee60f43ddab3492cbf6 /ext/curl/gstcurlhttpsrc.c | |
parent | 5bf092bd64684e4b1f1446c25b07b6771ce97ba6 (diff) | |
download | gstreamer-plugins-bad-6baa66a889624abc15813719d19ec39c68958df7.tar.gz |
curlhttpsrc: Does version set fail because of HTTP2
Check to see if setting CURL_HTTP_VERSION_2_0 failed due to lack of HTTP/2
support or some bigger underlying libcurl failure
https://bugzilla.gnome.org/show_bug.cgi?id=785878
Diffstat (limited to 'ext/curl/gstcurlhttpsrc.c')
-rw-r--r-- | ext/curl/gstcurlhttpsrc.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/ext/curl/gstcurlhttpsrc.c b/ext/curl/gstcurlhttpsrc.c index 1349464d8..10fb0259e 100644 --- a/ext/curl/gstcurlhttpsrc.c +++ b/ext/curl/gstcurlhttpsrc.c @@ -1003,8 +1003,15 @@ gst_curl_http_src_create_easy_handle (GstCurlHttpSrc * s) #ifdef CURL_VERSION_HTTP2 case GSTCURL_HTTP_VERSION_2_0: GST_DEBUG_OBJECT (s, "Setting version as HTTP/2.0"); - gst_curl_setopt_int (s, handle, CURLOPT_HTTP_VERSION, - CURL_HTTP_VERSION_2_0); + if (curl_easy_setopt (handle, CURLOPT_HTTP_VERSION, + CURL_HTTP_VERSION_2_0) != CURLE_OK) { + if (gst_curl_http_src_curl_capabilities->features & CURL_VERSION_HTTP2) { + GST_WARNING_OBJECT (s, + "Cannot set unsupported option CURLOPT_HTTP_VERSION"); + } else { + GST_INFO_OBJECT (s, "HTTP/2 unsupported by libcurl at this time"); + } + } break; #endif default: |