diff options
| author | Philippe Normand <philn@igalia.com> | 2021-05-17 10:49:41 +0100 |
|---|---|---|
| committer | GStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org> | 2021-05-30 00:16:10 +0000 |
| commit | 064428cb34572fa1a018ebbaba6925967ba99dc0 (patch) | |
| tree | 223a704d854f52c8b4fb2aaae752ff481a887e1d /ext | |
| parent | b1541a7470d4e20c04a14606de652a32c6ca0a4e (diff) | |
| download | gstreamer-plugins-bad-064428cb34572fa1a018ebbaba6925967ba99dc0.tar.gz | |
webrtcbin: Stop transceivers update after first SDP error
When invalid SDP is supplied, _update_transceiver_from_sdp_media() sets the
GError, so it is invalid to continue any further SDP processing, we have to exit
early when the first error is raised.
Fixes #1595
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2254>
Diffstat (limited to 'ext')
| -rw-r--r-- | ext/webrtc/gstwebrtcbin.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/ext/webrtc/gstwebrtcbin.c b/ext/webrtc/gstwebrtcbin.c index 07b373491..df5bc8e56 100644 --- a/ext/webrtc/gstwebrtcbin.c +++ b/ext/webrtc/gstwebrtcbin.c @@ -4865,6 +4865,8 @@ _update_transceivers_from_sdp (GstWebRTCBin * webrtc, SDPSource source, _update_transceiver_from_sdp_media (webrtc, sdp->sdp, i, stream, trans, bundled, bundle_idx, error); + if (error && *error) + goto done; } else if (_message_media_is_datachannel (sdp->sdp, i)) { _update_data_channel_from_sdp_media (webrtc, sdp->sdp, i, stream, error); |