diff options
| author | Sebastian Dröge <sebastian@centricular.com> | 2021-06-08 11:38:11 +0300 |
|---|---|---|
| committer | GStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org> | 2021-06-25 09:45:24 +0000 |
| commit | b7951fb897af6a06e8e102e5e8e7f4933205dcba (patch) | |
| tree | c944c53ac9ee72280570a792e2222cee3241060f /ext | |
| parent | 0f492a39c9ff01d63ab2ba908467e5ba253047ca (diff) | |
| download | gstreamer-plugins-bad-b7951fb897af6a06e8e102e5e8e7f4933205dcba.tar.gz | |
webrtcbin: Fix a couple of caps leaks of the offer caps
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2310>
Diffstat (limited to 'ext')
| -rw-r--r-- | ext/webrtc/gstwebrtcbin.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/ext/webrtc/gstwebrtcbin.c b/ext/webrtc/gstwebrtcbin.c index beadefd81..e0e8d305f 100644 --- a/ext/webrtc/gstwebrtcbin.c +++ b/ext/webrtc/gstwebrtcbin.c @@ -3718,6 +3718,7 @@ _create_answer_task (GstWebRTCBin * webrtc, const GstStructure * options, if (rtp_trans) gst_object_unref (rtp_trans); gst_caps_unref (answer_caps); + gst_caps_unref (offer_caps); goto rejected; } @@ -3732,6 +3733,7 @@ _create_answer_task (GstWebRTCBin * webrtc, const GstStructure * options, } else { trans = WEBRTC_TRANSCEIVER (rtp_trans); } + if (!_update_transceiver_kind_from_caps (rtp_trans, answer_caps)) GST_WARNING_OBJECT (webrtc, "Trying to change transceiver %d kind from %d to %d", @@ -3774,6 +3776,7 @@ _create_answer_task (GstWebRTCBin * webrtc, const GstStructure * options, if (answer_dir == GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_NONE) { GST_WARNING_OBJECT (webrtc, "Could not intersect offer direction with " "transceiver direction"); + gst_caps_unref (offer_caps); goto rejected; } _media_replace_direction (media, answer_dir); |