diff options
author | Seungha Yang <seungha@centricular.com> | 2021-09-17 23:23:06 +0900 |
---|---|---|
committer | Nicolas Dufresne <nicolas@ndufresne.ca> | 2021-09-20 13:03:44 +0000 |
commit | aaeb76f09c5e3c83439fbfebfd15f36767b34f0d (patch) | |
tree | be28d882ee7e96185e67e7b9c66cd7eddf0921b7 /gst-libs/gst/codecs/gstvp8decoder.h | |
parent | fcad4cc646a23e4e621ec5e8485958ab78d98090 (diff) | |
download | gstreamer-plugins-bad-aaeb76f09c5e3c83439fbfebfd15f36767b34f0d.tar.gz |
codecs: vp8decoder: Use GstFlowReturn everywhere
boolean return value is not sufficient for representing the reason
of error in most cases. For instance, any errors around new_sequence()
would mean negotiation error, not just *ERROR*.
And some subclasses will allocate buffer/memory/surface on new_picture()
but it could be failed because of expected error, likely flushing
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2528>
Diffstat (limited to 'gst-libs/gst/codecs/gstvp8decoder.h')
-rw-r--r-- | gst-libs/gst/codecs/gstvp8decoder.h | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/gst-libs/gst/codecs/gstvp8decoder.h b/gst-libs/gst/codecs/gstvp8decoder.h index 9541088b9..e147afb95 100644 --- a/gst-libs/gst/codecs/gstvp8decoder.h +++ b/gst-libs/gst/codecs/gstvp8decoder.h @@ -88,31 +88,31 @@ struct _GstVp8DecoderClass { GstVideoDecoderClass parent_class; - gboolean (*new_sequence) (GstVp8Decoder * decoder, + GstFlowReturn (*new_sequence) (GstVp8Decoder * decoder, const GstVp8FrameHdr * frame_hdr); /** - * GstVp8Decoder:new_picture: + * GstVp8DecoderClass:new_picture: * @decoder: a #GstVp8Decoder * @frame: (transfer none): a #GstVideoCodecFrame * @picture: (transfer none): a #GstVp8Picture */ - gboolean (*new_picture) (GstVp8Decoder * decoder, + GstFlowReturn (*new_picture) (GstVp8Decoder * decoder, GstVideoCodecFrame * frame, GstVp8Picture * picture); - gboolean (*start_picture) (GstVp8Decoder * decoder, + GstFlowReturn (*start_picture) (GstVp8Decoder * decoder, GstVp8Picture * picture); - gboolean (*decode_picture) (GstVp8Decoder * decoder, + GstFlowReturn (*decode_picture) (GstVp8Decoder * decoder, GstVp8Picture * picture, GstVp8Parser * parser); - gboolean (*end_picture) (GstVp8Decoder * decoder, + GstFlowReturn (*end_picture) (GstVp8Decoder * decoder, GstVp8Picture * picture); /** - * GstVp8Decoder:output_picture: + * GstVp8DecoderClass:output_picture: * @decoder: a #GstVp8Decoder * @frame: (transfer full): a #GstVideoCodecFrame * @picture: (transfer full): a #GstVp8Picture |