summaryrefslogtreecommitdiff
path: root/gst
diff options
context:
space:
mode:
authorEdward Hervey <edward@centricular.com>2016-10-02 09:34:51 +0200
committerEdward Hervey <bilboed@bilboed.com>2016-10-08 14:13:51 +0200
commit4aadf50012cb057422f29644b41fcaa30c1a2dd2 (patch)
tree6ea9aaf4f944e3523365a6b7dbca2f9021ecc5eb /gst
parent701e54cecfce85c2e2bdb3ae96b142c76400ed44 (diff)
downloadgstreamer-plugins-bad-4aadf50012cb057422f29644b41fcaa30c1a2dd2.tar.gz
adaptivedemux: Calculate values before queue2
In order to calculate the *actual* bitrate for downloading a fragment we need to take into account the time since we requested the fragment. Without this, the bitrate calculations (previously reported by queue2) would be biased since they wouldn't take into account the request latency (that is the time between the moment we request a specific URI and the moment we receive the first byte of that request). Such examples were it would be biased would be high-bandwith but high-latency networks. If you download 5MB in 500ms, but it takes 200ms to get the first byte, queue2 would report 80Mbit/s (5Mb in 500ms) , but taking the request into account it is only 57Mbit/s (5Mb in 700ms). While this would not cause too much issues if the above fragment represented a much longer duration (5s of content), it would cause issues with short ones (say 1s, or when doing keyframe-only requests which are even shorter) where the code would expect to be able to download up to 80Mbit/s ... whereas if we take the request time into account it's much lower (and we would therefore end up doing late requests). Also calculate the request latency for debugging purposes and further usage (it could allow us to figure out the maximum request rate for example). https://bugzilla.gnome.org/show_bug.cgi?id=733959 https://bugzilla.gnome.org/show_bug.cgi?id=772330
Diffstat (limited to 'gst')
0 files changed, 0 insertions, 0 deletions