diff options
| author | Olivier Crête <olivier.crete@collabora.com> | 2021-06-21 16:50:46 -0400 |
|---|---|---|
| committer | GStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org> | 2021-06-24 09:41:09 +0000 |
| commit | 71052f032109b0d64e84ac2d75913090e57a39d0 (patch) | |
| tree | 9da52f727ee4c23b7b5c3ce409448478537633ba /tests | |
| parent | 85c17f6c233e177cb4e7c720056b56be4974468f (diff) | |
| download | gstreamer-plugins-bad-71052f032109b0d64e84ac2d75913090e57a39d0.tar.gz | |
webrtcbin test: Fix race in new test
Pull a buffer from a sink to make sure that the caps are already
set before trying to update them.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2348>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/check/elements/webrtcbin.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tests/check/elements/webrtcbin.c b/tests/check/elements/webrtcbin.c index 405886ee3..a1253f07a 100644 --- a/tests/check/elements/webrtcbin.c +++ b/tests/check/elements/webrtcbin.c @@ -4074,6 +4074,7 @@ GST_START_TEST (test_codec_preferences_negotiation_srcpad) GstHarness *sink_harness = NULL; guint i; GstElement *rtpbin2; + GstBuffer *buf; t->on_negotiation_needed = NULL; t->on_ice_candidate = NULL; @@ -4108,6 +4109,13 @@ GST_START_TEST (test_codec_preferences_negotiation_srcpad) g_mutex_unlock (&t->lock); fail_unless (sink_harness->element == t->webrtc2); + /* Get one buffer out, this makes sure the capsfilter is primed and + * avoids races. + */ + buf = gst_harness_pull (sink_harness); + fail_unless (buf != NULL); + gst_buffer_unref (buf); + gst_harness_set_sink_caps_str (sink_harness, OPUS_RTP_CAPS (100)); test_webrtc_reset_negotiation (t); |