diff options
| author | Jan Schmidt <jan@centricular.com> | 2016-04-16 02:11:59 +1000 |
|---|---|---|
| committer | Jan Schmidt <jan@centricular.com> | 2016-04-16 22:49:10 +1000 |
| commit | be4a6ba49ee9263f6c9f7a17b672d21a7fc17861 (patch) | |
| tree | 760ac7ffd533b87a7f078aa9a9f606c29e59205e | |
| parent | d6d69ba17b7b3b834688c32edf774999c5fb817a (diff) | |
| download | gstreamer-plugins-base-1.6.tar.gz | |
Revert "audioringbuffer: start ringbuffer if needed upon commit"1.6
This reverts commit 13ee94ef1091f8a8a90dbd395b39876c26c5188e.
Causes audio glitches at startup by starting to output segments
from the ringbuffer before it has been filled / fully prerolled.
https://bugzilla.gnome.org/show_bug.cgi?id=657076
| -rw-r--r-- | gst-libs/gst/audio/gstaudioringbuffer.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/gst-libs/gst/audio/gstaudioringbuffer.c b/gst-libs/gst/audio/gstaudioringbuffer.c index 246c6f61c..14f3c22ef 100644 --- a/gst-libs/gst/audio/gstaudioringbuffer.c +++ b/gst-libs/gst/audio/gstaudioringbuffer.c @@ -1470,18 +1470,6 @@ default_commit (GstAudioRingBuffer * buf, guint64 * sample, g_return_val_if_fail (buf->memory != NULL, -1); g_return_val_if_fail (data != NULL, -1); - /* writing stuff now, ensure running clock */ - if (G_UNLIKELY (g_atomic_int_get (&buf->state) != - GST_AUDIO_RING_BUFFER_STATE_STARTED)) { - /* see if we are allowed to start it */ - if (G_UNLIKELY (g_atomic_int_get (&buf->may_start) == FALSE)) { - GST_DEBUG_OBJECT (buf, "not allowed to start"); - } else { - GST_DEBUG_OBJECT (buf, "start!"); - gst_audio_ring_buffer_start (buf); - } - } - need_reorder = buf->need_reorder; channels = buf->spec.info.channels; |