summaryrefslogtreecommitdiff
path: root/ext/libvisual
diff options
context:
space:
mode:
authorLuis de Bethencourt <luis.bg@samsung.com>2015-01-12 15:27:18 +0000
committerLuis de Bethencourt <luis.bg@samsung.com>2015-01-12 15:27:18 +0000
commit7cc048f4df3cd51b84a628021b9f8cf0a92045fe (patch)
tree5d88166804ecbd7a230bedc79ec909a1d1dff062 /ext/libvisual
parent32e6220cfd9740b095556529df59de7c9ce0c813 (diff)
downloadgstreamer-plugins-base-7cc048f4df3cd51b84a628021b9f8cf0a92045fe.tar.gz
visual: use unused value
ret is assigned but not used and in the next cycle of the loop it is overwritten with default_prepare_output_buffer (). If there is a flow error the function should return instead. CID #1226475
Diffstat (limited to 'ext/libvisual')
-rw-r--r--ext/libvisual/gstaudiovisualizer.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/ext/libvisual/gstaudiovisualizer.c b/ext/libvisual/gstaudiovisualizer.c
index 3d5a39cad..639f1e489 100644
--- a/ext/libvisual/gstaudiovisualizer.c
+++ b/ext/libvisual/gstaudiovisualizer.c
@@ -1150,6 +1150,8 @@ gst_audio_visualizer_chain (GstPad * pad, GstObject * parent,
if (klass->render) {
if (!klass->render (scope, inbuf, &outframe)) {
ret = GST_FLOW_ERROR;
+ gst_video_frame_unmap (&outframe);
+ goto beach;
} else {
/* run various post processing (shading and geometric transformation) */
/* FIXME: SHADER assumes 32bpp */