diff options
| author | Luis de Bethencourt <luis.bg@samsung.com> | 2015-01-13 16:09:49 +0000 |
|---|---|---|
| committer | Luis de Bethencourt <luis.bg@samsung.com> | 2015-01-13 16:09:49 +0000 |
| commit | d3a73827e017b3b5967664b2cb83fe0de185f700 (patch) | |
| tree | 5d88166804ecbd7a230bedc79ec909a1d1dff062 /ext/libvisual | |
| parent | a91d521a3602f33083405467db9454d422b9da1b (diff) | |
| download | gstreamer-plugins-base-d3a73827e017b3b5967664b2cb83fe0de185f700.tar.gz | |
Revert "visual: remove unnecessary variable"
This reverts commit a91d521a3602f33083405467db9454d422b9da1b.
Being a base class it is better to check the value instead of ignoring it since
a child class could be created that returns valuable information.
Diffstat (limited to 'ext/libvisual')
| -rw-r--r-- | ext/libvisual/gstaudiovisualizer.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/ext/libvisual/gstaudiovisualizer.c b/ext/libvisual/gstaudiovisualizer.c index f9eb5be02..639f1e489 100644 --- a/ext/libvisual/gstaudiovisualizer.c +++ b/ext/libvisual/gstaudiovisualizer.c @@ -726,6 +726,7 @@ gst_audio_visualizer_src_setcaps (GstAudioVisualizer * scope, GstCaps * caps) { GstVideoInfo info; GstAudioVisualizerClass *klass; + gboolean res; if (!gst_video_info_from_caps (&info, caps)) goto wrong_caps; @@ -750,7 +751,7 @@ gst_audio_visualizer_src_setcaps (GstAudioVisualizer * scope, GstCaps * caps) GST_MAP_READWRITE); if (klass->setup) - klass->setup (scope); + res = klass->setup (scope); GST_DEBUG_OBJECT (scope, "video: dimension %dx%d, framerate %d/%d", GST_VIDEO_INFO_WIDTH (&info), GST_VIDEO_INFO_HEIGHT (&info), @@ -761,7 +762,9 @@ gst_audio_visualizer_src_setcaps (GstAudioVisualizer * scope, GstCaps * caps) gst_pad_set_caps (scope->srcpad, caps); /* find a pool for the negotiated caps now */ - return gst_audio_visualizer_do_bufferpool (scope, caps); + res = gst_audio_visualizer_do_bufferpool (scope, caps); + + return res; /* ERRORS */ wrong_caps: |