summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBenjamin Otte <otte@redhat.com>2014-08-17 03:19:59 +0200
committerBenjamin Otte <otte@redhat.com>2014-08-17 03:19:59 +0200
commitd36bba293d9a169b87ff07d059db7b3897f400a2 (patch)
treeac62e504769c024dd5ec93ce2511fd3002d6110f
parentc1a063e1a43b20fe516b044e3a6a43812d7dd18b (diff)
downloadgtk+-d36bba293d9a169b87ff07d059db7b3897f400a2.tar.gz
checkbutton: Don't redundantly update states
States are set properly by GtkButton, there is no need to set them manually.
-rw-r--r--gtk/gtkcheckbutton.c12
-rw-r--r--gtk/gtkradiobutton.c13
2 files changed, 0 insertions, 25 deletions
diff --git a/gtk/gtkcheckbutton.c b/gtk/gtkcheckbutton.c
index 08c2260e08..47dc6bb100 100644
--- a/gtk/gtkcheckbutton.c
+++ b/gtk/gtkcheckbutton.c
@@ -529,7 +529,6 @@ gtk_real_check_button_draw_indicator (GtkCheckButton *check_button,
{
GtkWidget *widget;
GtkButton *button;
- GtkStateFlags state = 0;
gint x, y;
gint indicator_size;
gint indicator_spacing;
@@ -544,7 +543,6 @@ gtk_real_check_button_draw_indicator (GtkCheckButton *check_button,
gtk_widget_get_allocation (widget, &allocation);
baseline = gtk_widget_get_allocated_baseline (widget);
context = gtk_widget_get_style_context (widget);
- state = gtk_widget_get_state_flags (widget);
_gtk_check_button_get_props (check_button, &indicator_size, &indicator_spacing);
@@ -557,20 +555,10 @@ gtk_real_check_button_draw_indicator (GtkCheckButton *check_button,
y = CLAMP (baseline - indicator_size * button->priv->baseline_align,
0, allocation.height - indicator_size);
- state &= ~(GTK_STATE_FLAG_ACTIVE |
- GTK_STATE_FLAG_PRELIGHT);
-
- if (button->priv->activate_timeout || (button->priv->button_down && button->priv->in_button))
- state |= GTK_STATE_FLAG_ACTIVE;
-
- if (button->priv->in_button)
- state |= GTK_STATE_FLAG_PRELIGHT;
-
if (gtk_widget_get_direction (widget) == GTK_TEXT_DIR_RTL)
x = allocation.width - (indicator_size + x);
gtk_style_context_save (context);
- gtk_style_context_set_state (context, state);
gtk_render_background (context, cr,
border_width, border_width,
diff --git a/gtk/gtkradiobutton.c b/gtk/gtkradiobutton.c
index 69aab76f54..f61a361e15 100644
--- a/gtk/gtkradiobutton.c
+++ b/gtk/gtkradiobutton.c
@@ -831,7 +831,6 @@ gtk_radio_button_draw_indicator (GtkCheckButton *check_button,
GtkWidget *widget;
GtkButton *button;
GtkStyleContext *context;
- GtkStateFlags state = 0;
gint x, y;
gint indicator_size, indicator_spacing;
gint baseline;
@@ -840,7 +839,6 @@ gtk_radio_button_draw_indicator (GtkCheckButton *check_button,
widget = GTK_WIDGET (check_button);
button = GTK_BUTTON (check_button);
context = gtk_widget_get_style_context (widget);
- state = gtk_widget_get_state_flags (widget);
border_width = gtk_container_get_border_width (GTK_CONTAINER (widget));
_gtk_check_button_get_props (check_button, &indicator_size, &indicator_spacing);
@@ -855,21 +853,10 @@ gtk_radio_button_draw_indicator (GtkCheckButton *check_button,
y = CLAMP (baseline - indicator_size * button->priv->baseline_align,
0, allocation.height - indicator_size);
- state &= ~(GTK_STATE_FLAG_ACTIVE |
- GTK_STATE_FLAG_PRELIGHT);
-
- if (button->priv->activate_timeout ||
- (button->priv->button_down && button->priv->in_button))
- state |= GTK_STATE_FLAG_ACTIVE;
-
- if (button->priv->in_button)
- state |= GTK_STATE_FLAG_PRELIGHT;
-
if (gtk_widget_get_direction (widget) == GTK_TEXT_DIR_RTL)
x = allocation.width - (indicator_size + x);
gtk_style_context_save (context);
- gtk_style_context_set_state (context, state);
gtk_render_background (context, cr,
border_width, border_width,