diff options
| author | Emmanuele Bassi <ebassi@gnome.org> | 2020-11-17 14:40:52 +0000 |
|---|---|---|
| committer | Emmanuele Bassi <ebassi@gnome.org> | 2020-11-17 16:38:12 +0000 |
| commit | 153c6424d3aa983c3679a7ebf640d0b2b21fc26a (patch) | |
| tree | 95ad303259c619d3497b9d1452658472ada66182 /tests/testtooltips.c | |
| parent | 2b8c3731c1803228b5df1238015c6d971a57fa35 (diff) | |
| download | gtk+-153c6424d3aa983c3679a7ebf640d0b2b21fc26a.tar.gz | |
Remove pointless inout argumentsebassi/inout-args
GtkTreeView.get_tooltip_context() takes an inout X and Y coordinates,
but the "out" side is a side effect: the conversion from widget-relative
to bin window-relative coordinates is not documented, and can be done
using public API, if needed.
GtkIconView.get_tooltip_context() follows the same pattern, and takes
two inout arguments for the coordinates, but it does not change them any
more, after GtkIconView's bin window was dropped in commit 8dc5e13e.
There's really no point in having these `inout` arguments, and while
GtkTreeView and GtkIconView are certainly de-emphasised in GTK4, and we
nudge developers to move to the new list views, we should take advantage
of the API break to remove warts.
Diffstat (limited to 'tests/testtooltips.c')
| -rw-r--r-- | tests/testtooltips.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/testtooltips.c b/tests/testtooltips.c index 2cc4bf9c96..80f60b67cc 100644 --- a/tests/testtooltips.c +++ b/tests/testtooltips.c @@ -125,7 +125,7 @@ query_tooltip_tree_view_cb (GtkWidget *widget, char buffer[512]; - if (!gtk_tree_view_get_tooltip_context (tree_view, &x, &y, + if (!gtk_tree_view_get_tooltip_context (tree_view, x, y, keyboard_tip, &model, &path, &iter)) return FALSE; |