Add function vector-copy! to core

This is up to 20%-30% faster than the previous versions in (scheme base) or
(srfi srfi-43) that used vector-move-left!/vector-move-right!.

* libguile/vectors.h:
* libguile/vectors.c: As stated.
* doc/ref/api-data.texi (vector-copy!): Document the new function.
  (vector-fill!): Document optional arguments.
  (vector-copy): Document optional arguments.
* module/scheme/base.scm: Reuse core vector-copy!.
* module/srfi/srfi-43.scm: Reuse core vector-copy!.

2 files changed, 4 insertions, 30 deletions

diff --git a/module/scheme/base.scm b/module/scheme/base.scm
index c57bdf110..c6a73c092 100644
--- a/module/scheme/base.scm
+++ b/module/scheme/base.scm
@@ -57,7 +57,7 @@
             string->vector vector->string
             (r7:string->utf8 . string->utf8)
             (r7:vector->list . vector->list)
-            vector-copy! vector-append vector-for-each vector-map
+            vector-append vector-for-each vector-map
             (r7:bytevector-copy . bytevector-copy)
             (r7:bytevector-copy! . bytevector-copy!)
             (r7:utf8->string . utf8->string)
@@ -114,7 +114,7 @@
    (char-ready? . u8-ready?)
    unless
    unquote unquote-splicing values
-   vector vector-copy vector-fill!
+   vector vector-copy vector-copy! vector-fill!
    vector-length vector-ref vector-set! vector?
    when with-exception-handler write-char
    zero?))
@@ -431,19 +431,6 @@
 
 ;;; vector
 
-(define* (vector-copy! target tstart source
-                       #:optional (sstart 0) (send (vector-length source)))
-  "Copy a block of elements from SOURCE to TARGET, both of which must be
-vectors, starting in TARGET at TSTART and starting in SOURCE at SSTART,
-ending when SEND - SSTART elements have been copied.  It is an error for
-TARGET to have a length less than TSTART + (SEND - SSTART).  SSTART
-defaults to 0 and SEND defaults to the length of SOURCE."
-  (let ((tlen (vector-length target))
-        (slen (vector-length source)))
-    (if (< tstart sstart)
-        (vector-move-left!  source sstart send target tstart)
-        (vector-move-right! source sstart send target tstart))))
-
 (define r7:vector->list
   (case-lambda*
     ((v) (vector->list v))
diff --git a/module/srfi/srfi-43.scm b/module/srfi/srfi-43.scm
index f8e38e27c..18e97cf53 100644
--- a/module/srfi/srfi-43.scm
+++ b/module/srfi/srfi-43.scm
@@ -22,7 +22,7 @@
   #:use-module (srfi srfi-1)
   #:use-module (srfi srfi-8)
   #:re-export (make-vector vector vector? vector-ref vector-set!
-                           vector-length vector-fill!)
+                           vector-length vector-fill! vector-copy!)
   #:replace (vector-copy list->vector vector->list)
   #:export (vector-empty? vector= vector-unfold vector-unfold-right
                           vector-reverse-copy
@@ -35,7 +35,7 @@
                           vector-binary-search
                           vector-any vector-every
                           vector-swap! vector-reverse!
-                          vector-copy! vector-reverse-copy!
+                          vector-reverse-copy!
                           reverse-vector->list
                           reverse-list->vector))
 
@@ -933,19 +933,6 @@ START defaults to 0 and END defaults to the length of VEC."
              (error-from 'copy! "would write past end of target"))
            (%copy! target tstart source sstart send)))))))
 
-(define-vector-copier! vector-copy!
-  "(vector-copy! target tstart source [sstart [send]]) -> unspecified
-
-Copy a block of elements from SOURCE to TARGET, both of which must be
-vectors, starting in TARGET at TSTART and starting in SOURCE at
-SSTART, ending when SEND - SSTART elements have been copied.  It is an
-error for TARGET to have a length less than TSTART + (SEND - SSTART).
-SSTART defaults to 0 and SEND defaults to the length of SOURCE."
-  (lambda (target tstart source sstart send)
-    (if (< tstart sstart)
-        (vector-move-left!  source sstart send target tstart)
-        (vector-move-right! source sstart send target tstart))))
-
 (define-vector-copier! vector-reverse-copy!
   "(vector-reverse-copy! target tstart source [sstart [send]]) -> unspecified