Replace mutating mkdtemp! with non-mutating mkdtemp

* doc/ref/posix.texi: replace mkdtemp! and scm_mkdtemp_x documentation
    with documentation for mkdtemp and scm_mkdtemp
* libguile/filesys.c (scm_mkdtemp_x): procedure mkdtemp! removed
    (scm_mkdtemp): new procedure mkdtemp
* libguile/filesys.h: Remove declaration for scm_mkdtemp_x.  New declaration
    scm_mkdtemp.
* test-suite/tests/filesys.test: Remove mkdtemp! tests.  Add tests
    for mkdtemp.

1 files changed, 16 insertions, 21 deletions

diff --git a/test-suite/tests/filesys.test b/test-suite/tests/filesys.test
index 8ef4e396e..e61b96f6e 100644
--- a/test-suite/tests/filesys.test
+++ b/test-suite/tests/filesys.test
@@ -233,40 +233,35 @@
   (delete-file (test-symlink)))
 
 
-(with-test-prefix "mkdtemp!"
+(with-test-prefix "mkdtemp"
 
   (pass-if-exception "number arg" exception:wrong-type-arg
-    (if (not (defined? 'mkdtemp!))
+    (if (not (defined? 'mkdtemp))
         (throw 'unresolved)
-        (mkdtemp! 123)))
+        (mkdtemp 123)))
 
-  (pass-if "directory name template prefix is unmodified"
-    (if (not (defined? 'mkdtemp!))
+  (pass-if "template prefix is preserved"
+    (if (not (defined? 'mkdtemp))
         (throw 'unresolved)
-        (let ((template (string-copy "T-XXXXXX")))
-          (mkdtemp! template)
+        (let* ((template "T-XXXXXX")
+               (name (mkdtemp template)))
           (false-if-exception (rmdir template))
           (and
-           (string? template)
-           (string-contains template "T-")
-           (= (string-length template) 8)))))
-
-  (pass-if-exception "read-only template" exception:miscellaneous-error
-    (if (not (defined? 'mkdtemp!))
-        (throw 'unresolved)
-        (mkdtemp! (substring/read-only "T-XXXXXX" 0))))
+           (string? name)
+           (string-contains name "T-")
+           (= (string-length name) 8)))))
 
   (pass-if-exception "invalid template" exception:system-error
-    (if (not (defined? 'mkdtemp!))
+    (if (not (defined? 'mkdtemp))
         (throw 'unresolved)
-        (mkdtemp! (string-copy "T-AAAAAA" 0))))
+        (mkdtemp "T-AAAAAA")))
 
   (pass-if "directory created"
-    (if (not (defined? 'mkdtemp!))
+    (if (not (defined? 'mkdtemp))
         (throw 'unresolved)
-        (let ((template (string-copy "T-XXXXXX")))
-          (mkdtemp! template)
-          (let* ((_stat    (stat template))
+        (let* ((template "T-XXXXXX")
+               (name (mkdtemp template)))
+          (let* ((_stat    (stat name))
                  (result   (eqv? 'directory (stat:type _stat))))
             (false-if-exception (rmdir template))
             result)))))