summaryrefslogtreecommitdiff
path: root/NEWS
diff options
context:
space:
mode:
authorOndrej Holy <oholy@redhat.com>2019-10-10 09:34:02 +0200
committerOndrej Holy <oholy@redhat.com>2019-11-11 12:23:46 +0000
commita1e85edaa95d5f69c1aa4a883fb1d308e2ad8a3a (patch)
treeba074d18395c8601029362b5130f11b2e40e1090 /NEWS
parentf581a0aea03844752eff655393c5ddfc0e6d68df (diff)
downloadgvfs-a1e85edaa95d5f69c1aa4a883fb1d308e2ad8a3a.tar.gz
gdbus: Add workaround for deadlocks when cancelling jobs
GVfs calls gvfs_dbus_daemon_proxy_new() in cancelled signal handler which internally needs CONNECTION_LOCK(connection). The lock can be unfortunately held by gdbus worker thread which can call g_cancellable_disconnect(). This obviously leads to deadlocks. I don't see any reason why we have to block g_cancellable_disconnect() because of gvfs_dbus_daemon_proxy_new() resp. gvfs_dbus_daemon_call_cancel(). Let's call it over idle source to not block the cancelled signal handler in order to prevent the deadlocks. It would be better to fix this issue directly in gdbus codes, however, it is not fully clear to me, what is a proper way to fix this. https://gitlab.gnome.org/GNOME/glib/issues/1023
Diffstat (limited to 'NEWS')
0 files changed, 0 insertions, 0 deletions