diff options
| author | Alexander Larsson <alexl@redhat.com> | 2009-03-02 08:36:39 +0000 |
|---|---|---|
| committer | Alexander Larsson <alexl@src.gnome.org> | 2009-03-02 08:36:39 +0000 |
| commit | efc61cdd5d83a16988418d2bcdb240591167173c (patch) | |
| tree | 6adbb59f0ae7bc99c184f42a5053c9e5fa0102ea /client/gdaemonfileinputstream.c | |
| parent | b31808b6f6818d51bdcb1a81cca9e6c6db9724cd (diff) | |
| download | gvfs-efc61cdd5d83a16988418d2bcdb240591167173c.tar.gz | |
Bug 573371 – Unsafe g_htonl() macro expansion
2009-03-02 Alexander Larsson <alexl@redhat.com>
Bug 573371 – Unsafe g_htonl() macro expansion
* client/gdaemonfileoutputstream.c (append_request):
* client/gdaemonfileinputstream.c (append_request):
Don't use ++ inside macro that may evaluate twice.
svn path=/trunk/; revision=2263
Diffstat (limited to 'client/gdaemonfileinputstream.c')
| -rw-r--r-- | client/gdaemonfileinputstream.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/client/gdaemonfileinputstream.c b/client/gdaemonfileinputstream.c index 8b19fa07..63ad5ecc 100644 --- a/client/gdaemonfileinputstream.c +++ b/client/gdaemonfileinputstream.c @@ -406,11 +406,13 @@ append_request (GDaemonFileInputStream *stream, guint32 command, *seq_nr = stream->seq_nr; cmd.command = g_htonl (command); - cmd.seq_nr = g_htonl (stream->seq_nr++); + cmd.seq_nr = g_htonl (stream->seq_nr); cmd.arg1 = g_htonl (arg1); cmd.arg2 = g_htonl (arg2); cmd.data_len = g_htonl (data_len); + stream->seq_nr++; + g_string_append_len (stream->output_buffer, (char *)&cmd, G_VFS_DAEMON_SOCKET_PROTOCOL_REQUEST_SIZE); } |