diff options
| author | Ondrej Holy <oholy@redhat.com> | 2017-01-24 14:29:57 +0100 |
|---|---|---|
| committer | Ondrej Holy <oholy@redhat.com> | 2017-02-07 08:14:29 +0100 |
| commit | 1f64137766fad0d7a24044f9b1f725e374eda5b6 (patch) | |
| tree | e5c10052ffed0974e0391af561a383eea06df49d /client | |
| parent | 11ac3b0351468099fc472745262c0b81f4de6732 (diff) | |
| download | gvfs-1f64137766fad0d7a24044f9b1f725e374eda5b6.tar.gz | |
client: Do not leak GDBusConnection reference
async_construct_proxy() calls g_object_ref() on connection, because
the connection is unrefed by async_call_finish(). The returned connection
might be NULL in some cases and g_bus_get() is called instead. However,
g_bus_get_finish() is "transfer full" and thus one reference is leaked.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
Diffstat (limited to 'client')
| -rw-r--r-- | client/gdaemonfile.c | 1 | ||||
| -rw-r--r-- | client/gdaemonmount.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/client/gdaemonfile.c b/client/gdaemonfile.c index abc81cf7..ac24014c 100644 --- a/client/gdaemonfile.c +++ b/client/gdaemonfile.c @@ -626,6 +626,7 @@ bus_get_cb (GObject *source_object, } async_construct_proxy (connection, data); + g_object_unref (connection); } static void diff --git a/client/gdaemonmount.c b/client/gdaemonmount.c index 9bba2d13..d49fad89 100644 --- a/client/gdaemonmount.c +++ b/client/gdaemonmount.c @@ -303,6 +303,7 @@ bus_get_cb (GObject *source_object, } async_construct_proxy (connection, task); + g_object_unref (connection); } static void |