diff options
| author | Bastien Nocera <hadess@hadess.net> | 2016-10-28 14:00:01 +0200 |
|---|---|---|
| committer | Bastien Nocera <hadess@hadess.net> | 2016-11-02 11:59:38 +0100 |
| commit | de970102f8d917fe546bfaa600aa2a4074152c46 (patch) | |
| tree | 0973f493d6b02058a2e041bb7d0c14d2cf0ee074 /daemon/gvfsbackendsmb.c | |
| parent | 6df182c89ab05bd06f8b351f4096f699366e283f (diff) | |
| download | gvfs-de970102f8d917fe546bfaa600aa2a4074152c46.tar.gz | |
smb: Remove maximum read size during reads
The smb read call can take any arbitrary size and the both the
libsmbclient SMB1 and SMB2 engines will break this down into as
many simultaneous on the wire calls as needed to pipeline
the reads / writes.
Restricting this to 65534 will be slow, so remove this
restriction.
See https://lists.samba.org/archive/samba/2016-October/204225.html
https://bugzilla.gnome.org/show_bug.cgi?id=773632
Diffstat (limited to 'daemon/gvfsbackendsmb.c')
| -rw-r--r-- | daemon/gvfsbackendsmb.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/daemon/gvfsbackendsmb.c b/daemon/gvfsbackendsmb.c index adad9ade..12fbd385 100644 --- a/daemon/gvfsbackendsmb.c +++ b/daemon/gvfsbackendsmb.c @@ -704,14 +704,6 @@ do_read (GVfsBackend *backend, ssize_t res; smbc_read_fn smbc_read; - /* libsmbclient limits blocksize to (64*1024)-2 for Windows servers, - * let's do the same here to achieve reasonable performance. (#588391) - * - * TODO: port to pull mechanism (#592468) - */ - if (bytes_requested > 65534) - bytes_requested = 65534; - smbc_read = smbc_getFunctionRead (op_backend->smb_context); res = smbc_read (op_backend->smb_context, (SMBCFILE *)handle, buffer, bytes_requested); |