diff options
author | Philip Langdale <philipl@overt.org> | 2018-03-17 12:35:54 -0700 |
---|---|---|
committer | Philip Langdale <philipl@overt.org> | 2018-03-26 19:34:03 -0700 |
commit | 528ac6f989beb2e89beb9732f7bfe9eefcd8e036 (patch) | |
tree | 8b0b59e99590f63c7b34e1adc5dec507ff68cf6c /test | |
parent | c4cf671d1c845488d512b2cabac50fb49bf767d8 (diff) | |
download | gvfs-528ac6f989beb2e89beb9732f7bfe9eefcd8e036.tar.gz |
mtp: Refactor source/dest file/dir validation logic
There is a fairly elaborate set of conditions that need to be
respected when copying or moving files. Right now, we've got this
logic duplicated in four different places (push/pull/move/copy),
so it's worth the effort to consolidate that logic into a single
place.
Along the way, I'm deliberately ignoring the ability of CopyObject
to copy folders. By forcing the client to do file-by-file copies,
we can at least notify when each file completes, to provide slightly
better progress reports. There is a performance impact - I suspect
that a large directory of small files will end up being orders of
magnitude slower, but for a small number of files, it's negligible.
I have not done this for MoveObject, because that is fast unless
the source and target are on different Storages - and devices
with multiple storages are getting less and less common.
https://bugzilla.gnome.org/show_bug.cgi?id=794388
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions