summaryrefslogtreecommitdiff
path: root/daemon/gvfsafpconnection.c
Commit message (Collapse)AuthorAgeFilesLines
* afp: Fix afp backend crash when no username suppliedMayank Sharma2019-03-281-0/+6
| | | | | | | | A missing NULL check in g_vfs_afp_command_put_pascal caused crashes (seg faults) when no username was given. Crashes happened irrespective of Password was given or not. https://gitlab.gnome.org/GNOME/gvfs/issues/298
* daemon: Don't use deprecated private structure APIsOndrej Holy2018-07-101-7/+3
| | | | | | | g_type_class_add_private and G_TYPE_INSTANCE_GET_PRIVATE have been recently deprecated. Let's use rather G_DEFINE_TYPE_WITH_PRIVATE and _get_instance_private() instead in order to prevent deprecation warnings.
* afp: Port GVfsAfpConnection to GTaskOndrej Holy2017-11-281-145/+71
| | | | | | GSimpleAsyncResult is deprecated in favour of GTask and should be replaced. https://bugzilla.gnome.org/show_bug.cgi?id=747412
* afp: Prevent comparsion between signed and unsignedOndrej Holy2017-11-281-2/+2
| | | | | | | | Swap gssize and gsize data types in order to prevent comparisons and other operations between signed and unsigned types, which might lead to troubles. https://bugzilla.gnome.org/show_bug.cgi?id=747412
* afp: Change g_error to g_warning for read errorsOndrej Holy2015-08-291-4/+4
| | | | | | | | | | | Use g_warning rather than g_error when a read error occurs to prevent spurious crash reports since there are many different ways for a read from the network to fail. [Cherry-picked from gnome-3-14/14369db2a8fc Commit message written by Ross Lagerwall.] https://bugzilla.gnome.org/show_bug.cgi?id=710490
* Unify strings to ease translationFelix Möller2015-08-051-1/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=657906
* afp: exit silently if connection closedOndrej Holy2015-03-041-2/+4
| | | | | | | | | Commit c15ec62 introduced exit for G_IO_ERROR_CLOSED, however we should check also for G_IO_ERROR_CONNECTION_CLOSED. Bump GLib dependency to 2.43.2, where the error was introduced. https://bugzilla.gnome.org/show_bug.cgi?id=710490
* afp: Use UTF-8 for volume namesRoss Lagerwall2014-09-271-5/+23
| | | | | | | | | | | | Use UTF-8 for volume names since volume names are encoded as UTF-8 for protocol versions 3.0 and higher. This prevents seeing volume names like: "John’s Public Folder" Since the volume name comes as a pascal string with UTF-8 encoding, extend the function to read pascal strings with the ability to read pascal strings encoded as UTF-8. https://bugzilla.gnome.org/show_bug.cgi?id=733996
* afp: Don't retry read if connection closesRoss Lagerwall2014-08-031-4/+25
| | | | | | | | Don't retry the read if the remote host closes the connection. Instead, exit (semi-)gracefully with exit(0) and exit with an error if there was an actual error. https://bugzilla.gnome.org/show_bug.cgi?id=710490
* afp: Fix race between writing and readingRoss Lagerwall2014-07-171-9/+7
| | | | | | | | | | | | | | | | | | | | | The following sequence of events is possible in GVfsAfpConnection: send_request_unlocked write_dsi_header_cb ... return to main loop ... read_dsi_header_cb write_command_cb This happens if the server sends its response before the main loop gets a chance to run since write_command_cb is executed asynchronously as an idle function. It causes the job to hang because the request is only stored in the request hash table in write_command_cb and so the response is ignored when being processed because it cannot find the corresponding request. To fix this, store the request in the hash table before the request is written. https://bugzilla.gnome.org/show_bug.cgi?id=733133
* afp: Disable Nagle's algorithmRoss Lagerwall2014-07-151-3/+16
| | | | | | | | | | | | | | | | Disable Nagle's algorithm for the connection to the server to improve performance. Due to the backend doing a write-write-read sequence, the combination of Nagle's algorithm and TCP delayed ACKs means that the second write is delayed until the server's delayed ACK timer times out (40ms on Linux). This results in each request-response taking far too long causing poor performance. This patch reduces the time it takes to duplicate a directory of 10000 small files from 21 minutes to 11 seconds. https://bugzilla.gnome.org/show_bug.cgi?id=733217
* Fix use of uninitialized valuesTomas Bzatek2012-12-071-1/+1
|
* afp: fix g_vfs_afp_connection_get_max_request() not returning any valueCarl-Anton Ingmarsson2012-08-201-0/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=682283
* afp: use a separate request id counter for tickle requestsCarl-Anton Ingmarsson2012-08-091-1/+10
|
* afp: Fix crasher in GVfsAfpConnection when sending tickle requests.Carl-Anton Ingmarsson2012-08-091-0/+1
|
* afp: Fix issues with closing a GVfsAfpConnection.Carl-Anton Ingmarsson2012-08-091-20/+21
| | | | We ended up running close_connection() multiple times due to g_main_loop_quit() dispatching other sources.
* afp: Fix invalid free in GVfsAfpConnectionCarl-Anton Ingmarsson2012-08-091-0/+1
|
* afp: Don't create write requests bigger than the maximum request size.Carl-Anton Ingmarsson2012-08-091-0/+6
|
* afp: use g_thread_new() instead of deprecated g_thread_create()Carl-Anton Ingmarsson2012-08-091-8/+2
|
* Use a worker thread in GVfsAfpConnectionCarl-Anton Ingmarsson2012-08-091-157/+393
|
* afp: append _sync to g_vfs_afp_connection_[open|close]Carl-Anton Ingmarsson2012-08-091-6/+6
|
* Update the Address of the FSFFelix Möller2012-07-301-2/+2
| | | | | | | | | | | | | | | Updating the address of the FSF. This has been done by: while read file; do sed -i 's:59 Temple Place:51 Franklin Street:' $file sed -i 's:Suite 330:Fifth Floor:' $file sed -i 's:02111-1307:02110-1301:' $file done https://bugzilla.gnome.org/show_bug.cgi?id=656598 Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
* afp: convert pascal strings into utf-8Carl-Anton Ingmarsson2012-04-221-1/+4
| | | | | | | pascal strings are in the macintosh-roman character set and therefore need to be converted into utf-8. https://bugzilla.gnome.org/show_bug.cgi?id=674528
* afp: split out volume specific functions into a GVfsAfpVolume object.Carl-Anton Ingmarsson2012-01-221-0/+40
|
* afp: change g_vfs_afp_connection_get_server_info to g_vfs_afp_query_server_infoCarl-Anton Ingmarsson2012-01-221-88/+85
| | | | It's unnecessary to create a GVfsAfpConnection to retreive the server info
* afp: do some string fixes and add some translator commentsCarl-Anton Ingmarsson2012-01-221-1/+1
|
* afp: make GVfsAfpName an opaque typeCarl-Anton Ingmarsson2012-01-221-0/+8
|
* Revert "afp: start read loop directly on connect"Carl-Anton Ingmarsson2011-08-261-5/+11
| | | | This reverts commit 5c1242031634859004ce330581342c273a251d20.
* Revert "afp: reuse g_vfs_afp_connection_send_command in the sync version"Carl-Anton Ingmarsson2011-08-261-70/+57
| | | | This reverts commit ecc1730d3bfdc11fa07f15893267a7ea054328f1.
* afp: start read loop directly on connectCarl-Anton Ingmarsson2011-08-251-11/+5
| | | | | also change g_vfs_afp_connection_get_server_info to take a GSocketConnectable instead of a GVfsAfpConnection
* afp: reuse g_vfs_afp_connection_send_command in the sync versionCarl-Anton Ingmarsson2011-08-251-57/+70
|
* afp: fix some memoryleaksCarl-Anton Ingmarsson2011-08-251-49/+49
| | | | | | change g_vfs_afp_connection_send_command to take a "char *reply_buf" paramater to use for storing the reply data instead of reusing the buf data pointer in GVfsAfpCommand
* afp: fix some leaks of GSimpleAsyncResultsCarl-Anton Ingmarsson2011-08-251-4/+6
|
* afp: read directly into the given read bufferCarl-Anton Ingmarsson2011-08-251-15/+53
| | | | this way we can skip an memcpy and gain some extra performance
* afp: add a read_all_async functionCarl-Anton Ingmarsson2011-08-251-32/+120
|
* afp: avoid useless copy when writingCarl-Anton Ingmarsson2011-08-251-74/+198
|
* afp: fix compile warningsCarl-Anton Ingmarsson2011-08-251-3/+4
|
* afp: fix bug where we accidentaly popped two requests from the send queueCarl-Anton Ingmarsson2011-08-251-1/+0
|
* afp: use goffset in g_vfs_afp_reply_seekCarl-Anton Ingmarsson2011-08-251-2/+2
|
* afp: fix bug when sending DsiTickle commandsCarl-Anton Ingmarsson2011-08-251-2/+1
| | | | we accidentally stopped sending requests
* afp: print some debug upon DSI_CLOSE_SESSION and DSI_TICKLECarl-Anton Ingmarsson2011-08-251-32/+51
|
* afp: small cosmetic changeCarl-Anton Ingmarsson2011-08-251-1/+1
|
* afp: don't send commands which have been cancelledCarl-Anton Ingmarsson2011-08-251-6/+27
|
* afp: convert g_vfs_afp_connection_queue_command to the standard GIO async ↵Carl-Anton Ingmarsson2011-08-251-91/+147
| | | | | | pattern also rename it to g_vfs_afp_connection_send_command
* afp: fix invalid unrefCarl-Anton Ingmarsson2011-08-251-3/+3
|
* afp: delete temporary fileCarl-Anton Ingmarsson2011-08-251-5/+8
|
* afp: receive and print out server messagesCarl-Anton Ingmarsson2011-08-251-26/+19
|
* afp: dispatch DSI_WRITE repliesCarl-Anton Ingmarsson2011-08-251-1/+1
|
* afp: normalize utf-8 strings from the serverCarl-Anton Ingmarsson2011-08-251-1/+1
|
* afp: add g_vfs_afp_command_put_[byte|int|uint] functions and use theseCarl-Anton Ingmarsson2011-08-251-25/+64
|