| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
A missing NULL check in g_vfs_afp_command_put_pascal caused
crashes (seg faults) when no username was given. Crashes happened
irrespective of Password was given or not.
https://gitlab.gnome.org/GNOME/gvfs/issues/298
|
|
|
|
|
|
|
| |
g_type_class_add_private and G_TYPE_INSTANCE_GET_PRIVATE have been
recently deprecated. Let's use rather G_DEFINE_TYPE_WITH_PRIVATE
and _get_instance_private() instead in order to prevent deprecation
warnings.
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
|
|
| |
Swap gssize and gsize data types in order to prevent comparisons and
other operations between signed and unsigned types, which might lead
to troubles.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
|
|
|
|
|
| |
Use g_warning rather than g_error when a read error occurs to prevent
spurious crash reports since there are many different ways for a read
from the network to fail.
[Cherry-picked from gnome-3-14/14369db2a8fc
Commit message written by Ross Lagerwall.]
https://bugzilla.gnome.org/show_bug.cgi?id=710490
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=657906
|
|
|
|
|
|
|
|
|
| |
Commit c15ec62 introduced exit for G_IO_ERROR_CLOSED, however we
should check also for G_IO_ERROR_CONNECTION_CLOSED.
Bump GLib dependency to 2.43.2, where the error was introduced.
https://bugzilla.gnome.org/show_bug.cgi?id=710490
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use UTF-8 for volume names since volume names are encoded as UTF-8 for
protocol versions 3.0 and higher. This prevents seeing volume names
like: "John’s Public Folder"
Since the volume name comes as a pascal string with UTF-8 encoding,
extend the function to read pascal strings with the ability to read
pascal strings encoded as UTF-8.
https://bugzilla.gnome.org/show_bug.cgi?id=733996
|
|
|
|
|
|
|
|
| |
Don't retry the read if the remote host closes the connection. Instead,
exit (semi-)gracefully with exit(0) and exit with an error if there was
an actual error.
https://bugzilla.gnome.org/show_bug.cgi?id=710490
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following sequence of events is possible in GVfsAfpConnection:
send_request_unlocked
write_dsi_header_cb
... return to main loop ...
read_dsi_header_cb
write_command_cb
This happens if the server sends its response before the main loop gets
a chance to run since write_command_cb is executed asynchronously as an
idle function. It causes the job to hang because the request is only
stored in the request hash table in write_command_cb and so the response
is ignored when being processed because it cannot find the corresponding
request.
To fix this, store the request in the hash table before the request is
written.
https://bugzilla.gnome.org/show_bug.cgi?id=733133
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable Nagle's algorithm for the connection to the server to improve
performance.
Due to the backend doing a write-write-read sequence, the combination of
Nagle's algorithm and TCP delayed ACKs means that the second write is
delayed until the server's delayed ACK timer times out (40ms on Linux).
This results in each request-response taking far too long causing poor
performance.
This patch reduces the time it takes to duplicate a directory of 10000
small files from 21 minutes to 11 seconds.
https://bugzilla.gnome.org/show_bug.cgi?id=733217
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=682283
|
| |
|
| |
|
|
|
|
| |
We ended up running close_connection() multiple times due to g_main_loop_quit() dispatching
other sources.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updating the address of the FSF.
This has been done by:
while read file; do
sed -i 's:59 Temple Place:51 Franklin Street:' $file
sed -i 's:Suite 330:Fifth Floor:' $file
sed -i 's:02111-1307:02110-1301:' $file
done
https://bugzilla.gnome.org/show_bug.cgi?id=656598
Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
|
|
|
|
|
|
|
| |
pascal strings are in the macintosh-roman character set and therefore need to
be converted into utf-8.
https://bugzilla.gnome.org/show_bug.cgi?id=674528
|
| |
|
|
|
|
| |
It's unnecessary to create a GVfsAfpConnection to retreive the server info
|
| |
|
| |
|
|
|
|
| |
This reverts commit 5c1242031634859004ce330581342c273a251d20.
|
|
|
|
| |
This reverts commit ecc1730d3bfdc11fa07f15893267a7ea054328f1.
|
|
|
|
|
| |
also change g_vfs_afp_connection_get_server_info to take a GSocketConnectable
instead of a GVfsAfpConnection
|
| |
|
|
|
|
|
|
| |
change g_vfs_afp_connection_send_command to take a "char *reply_buf" paramater
to use for storing the reply data instead of reusing the buf data pointer in
GVfsAfpCommand
|
| |
|
|
|
|
| |
this way we can skip an memcpy and gain some extra performance
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
we accidentally stopped sending requests
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
pattern
also rename it to g_vfs_afp_connection_send_command
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|