summaryrefslogtreecommitdiff
path: root/HACKING.md
diff options
context:
space:
mode:
authorBen Gamari <ben@smart-cactus.org>2017-04-04 12:07:25 -0400
committerBen Gamari <ben@smart-cactus.org>2017-04-04 12:07:25 -0400
commit5e968f9261b798222a845ef38a54621b45013678 (patch)
treeb9f9dd14792d8e71520b4759e07549c1e8933270 /HACKING.md
parente83af07e3d0b65fe6f37806e86d07f3e8dc1b01e (diff)
downloadhaskell-5e968f9261b798222a845ef38a54621b45013678.tar.gz
HACKING: Update for Phabricator patch workflow
Diffstat (limited to 'HACKING.md')
-rw-r--r--HACKING.md33
1 files changed, 9 insertions, 24 deletions
diff --git a/HACKING.md b/HACKING.md
index 6ed39eaf1c..ecfd35b50e 100644
--- a/HACKING.md
+++ b/HACKING.md
@@ -49,13 +49,11 @@ $ cp mk/build.mk.sample mk/build.mk
$ ... double-check mk/build.mk ...
```
-Now build. If you have multiple cores, **you should always use them to
-speed up compilation**:
+Now build. The convenient `validate` script will build the tree in a way which
+is both quick to build and consistent with our testsuite,
```
-$ ./boot
-$ ./configure
-$ make -jN # <N> is the number of cores you have.
+$ ./validate --build-only
```
You can use the `./inplace/bin/ghc-stage2` binary to play with the
@@ -63,26 +61,13 @@ newly built compiler.
Now, hack on your copy and rebuild (with `make`) as necessary.
-Then start by making your commits however you want. When you're done, you
-can use `git format-patch` to create a series of `.patch` files you
-can give to us. In this example, we'll assume I'm on a `bugfix` branch
-and want to submit my patches:
+Then start by making your commits however you want. When you're done, you'll
+need to submit your patch to [Phabricator](https://phabricator.haskell.org/) for
+code review. To do so you will need to
+[install Arcanist](https://secure.phabricator.com/book/phabricator/article/arcanist/#installing-arcanist),
+Phabricator's CLI tool. Once installed, you can submit your work for code review
+using `arc diff`.
-```
-$ git branch
-* bugfix
- master
-$ git format-patch master -o patches
-...
-$
-```
-
-Now create a trac ticket:
-
-<http://ghc.haskell.org/trac/ghc/newticket?type=bug>
-
-And attach the files in your `patches/` directory. Set the status from
-*new* to *patch* and we'll review it as soon as we can!
Useful links:
=============