diff options
| author | Sylvain Henry <sylvain@haskus.fr> | 2021-08-12 17:44:15 +0200 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2021-09-11 08:54:29 -0400 |
| commit | 089de88ef5215de0f2db4c4babc556ac43f8232e (patch) | |
| tree | c036813b9625dbb45b4577b09ec6ad31c45c1bce /compiler/GHC/ByteCode | |
| parent | 74a87aa3046f3eb871e5442579e9a2945ef691d4 (diff) | |
| download | haskell-089de88ef5215de0f2db4c4babc556ac43f8232e.tar.gz | |
Canonicalize bignum literals
Before this patch Integer and Natural literals were desugared into "real"
Core in Core prep. Now we desugar them directly into their final ConApp
form in HsToCore. We only keep the double representation for BigNat#
(literals larger than a machine Word/Int) which are still desugared in
Core prep.
Using the final form directly allows case-of-known-constructor to fire
for bignum literals, fixing #20245.
Slight increase (+2.3) in T4801 which is a pathological case with
Integer literals.
Metric Increase:
T4801
T11545
Diffstat (limited to 'compiler/GHC/ByteCode')
| -rw-r--r-- | compiler/GHC/ByteCode/Asm.hs | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/compiler/GHC/ByteCode/Asm.hs b/compiler/GHC/ByteCode/Asm.hs index da03d2a903..1d7402c9cf 100644 --- a/compiler/GHC/ByteCode/Asm.hs +++ b/compiler/GHC/ByteCode/Asm.hs @@ -488,8 +488,7 @@ assembleI platform i = case i of LitNumWord32 -> int32 (fromIntegral i) LitNumInt64 -> int64 (fromIntegral i) LitNumWord64 -> int64 (fromIntegral i) - LitNumInteger -> panic "GHC.ByteCode.Asm.literal: LitNumInteger" - LitNumNatural -> panic "GHC.ByteCode.Asm.literal: LitNumNatural" + LitNumBigNat -> panic "GHC.ByteCode.Asm.literal: LitNumBigNat" -- We can lower 'LitRubbish' to an arbitrary constant, but @NULL@ is most -- likely to elicit a crash (rather than corrupt memory) in case absence |