diff options
| author | sheaf <sam.derbyshire@gmail.com> | 2023-05-15 15:23:49 +0200 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2023-05-15 18:03:00 -0400 |
| commit | 4d29ecdfcc79ad663e066d9f7d6d17b64c8c6c41 (patch) | |
| tree | 985890c63aee54a2e94e31aa85cbec44652987b9 /compiler/GHC/Tc/Module.hs-boot | |
| parent | d69cbd78999071d2d6479be40ae90ddd83b9942a (diff) | |
| download | haskell-4d29ecdfcc79ad663e066d9f7d6d17b64c8c6c41.tar.gz | |
Migrate errors to diagnostics in GHC.Tc.Module
This commit migrates the errors in GHC.Tc.Module to use the new
diagnostic infrastructure.
It required a significant overhaul of the compatibility checks between
an hs-boot or signature module and its implementation; we now use
a Writer monad to accumulate errors; see the BootMismatch datatype
in GHC.Tc.Errors.Types, with its panoply of subtypes.
For the sake of readability, several local functions inside the
'checkBootTyCon' function were split off into top-level functions.
We split off GHC.Types.HscSource into a "boot or sig" vs "normal hs file"
datatype, as this mirrors the logic in several other places where we
want to treat hs-boot and hsig files in a similar fashion.
This commit also refactors the Backpack checks for type synonyms
implementing abstract data, to correctly reject implementations that
contain qualified or quantified types (this fixes #23342 and #23344).
Diffstat (limited to 'compiler/GHC/Tc/Module.hs-boot')
| -rw-r--r-- | compiler/GHC/Tc/Module.hs-boot | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/compiler/GHC/Tc/Module.hs-boot b/compiler/GHC/Tc/Module.hs-boot index 40d89fe727..12a88ba72d 100644 --- a/compiler/GHC/Tc/Module.hs-boot +++ b/compiler/GHC/Tc/Module.hs-boot @@ -1,12 +1,7 @@ module GHC.Tc.Module where -import GHC.Prelude +import GHC.Types.SourceFile(HsBootOrSig) import GHC.Types.TyThing(TyThing) -import GHC.Tc.Errors.Types (TcRnMessage) import GHC.Tc.Types (TcM) -import GHC.Types.Name (Name) -checkBootDeclM :: Bool -- ^ True <=> an hs-boot file (could also be a sig) - -> TyThing -> TyThing -> TcM () -missingBootThing :: Bool -> Name -> String -> TcRnMessage -badReexportedBootThing :: Bool -> Name -> Name -> TcRnMessage +checkBootDeclM :: HsBootOrSig -> TyThing -> TyThing -> TcM () |