diff options
| author | Ben Gamari <ben@smart-cactus.org> | 2015-06-16 20:04:02 +0200 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2015-06-16 20:04:02 +0200 |
| commit | 0d6c97ba1267a53825809f3c99364f7aa38f0847 (patch) | |
| tree | 909024bee2d533ffa1130e96a89b574846d097cc /compiler/parser | |
| parent | df63736341d8b92c0f7f0012bf88929e32a1403f (diff) | |
| parent | 1ff7f09b3abedb2a6daf384b55ad3d0134f0d174 (diff) | |
| download | haskell-0d6c97ba1267a53825809f3c99364f7aa38f0847.tar.gz | |
Lexer: Suggest adding 'let' on unexpected '=' token
Summary:
I've heard numerous fledgling Haskeller's complain about the behavior of
ghci regarding bindings. While most REPLs accept bindings of the form
`x = 42`, GHCi is implicitly a `do` block, meaning that the user must
know to use a `let` to introduce a binding.
Here we suggest to the user that they may need a `let` and give them a
small example in the event that we find an unexpected `=` token.
Reviewers: austin
Reviewed By: austin
Subscribers: thomie, bgamari
Differential Revision: https://phabricator.haskell.org/D980
Diffstat (limited to 'compiler/parser')
| -rw-r--r-- | compiler/parser/Lexer.x | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/compiler/parser/Lexer.x b/compiler/parser/Lexer.x index 1be724526f..5839a410fb 100644 --- a/compiler/parser/Lexer.x +++ b/compiler/parser/Lexer.x @@ -2229,6 +2229,9 @@ srcParseErr dflags buf len (text "Perhaps you intended to use TemplateHaskell") $$ ppWhen (token == "<-") (text "Perhaps this statement should be within a 'do' block?") + $$ ppWhen (token == "=") + (text "Perhaps you need a 'let' in a 'do' block?" + $$ text "e.g. 'let x = 5' instead of 'x = 5'") where token = lexemeToString (offsetBytes (-len) buf) len th_enabled = xopt Opt_TemplateHaskell dflags |