diff options
| author | Michiel de Bruijne <m.debruijne@matrict.nl> | 2021-01-05 09:44:11 -0500 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2021-02-22 18:26:52 -0500 |
| commit | e1f133bf5ee30f25a94b4f3bf4d26d1a9381f0d9 (patch) | |
| tree | 6ff9aa4b04431c57ce6c207a2017cd1e051615f6 /compiler | |
| parent | f90487cacb16e8398c4c4a84de5a1e33ac4e7867 (diff) | |
| download | haskell-e1f133bf5ee30f25a94b4f3bf4d26d1a9381f0d9.tar.gz | |
Prefer -Wmissing-signatures over -Wmissing-exported-signatures (#14794)
Diffstat (limited to 'compiler')
| -rw-r--r-- | compiler/GHC/Rename/Names.hs | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/compiler/GHC/Rename/Names.hs b/compiler/GHC/Rename/Names.hs index 99d2089799..6dff5b195e 100644 --- a/compiler/GHC/Rename/Names.hs +++ b/compiler/GHC/Rename/Names.hs @@ -1480,16 +1480,16 @@ warnMissingSignatures gbl_env ; warn_pat_syns <- woptM Opt_WarnMissingPatternSynonymSignatures ; let add_sig_warns - | warn_only_exported = add_warns Opt_WarnMissingExportedSignatures | warn_missing_sigs = add_warns Opt_WarnMissingSignatures + | warn_only_exported = add_warns Opt_WarnMissingExportedSignatures | warn_pat_syns = add_warns Opt_WarnMissingPatternSynonymSignatures | otherwise = return () add_warns flag - = when warn_pat_syns - (mapM_ add_pat_syn_warn pat_syns) >> - when (warn_missing_sigs || warn_only_exported) - (mapM_ add_bind_warn binds) + = when (warn_missing_sigs || warn_only_exported) + (mapM_ add_bind_warn binds) >> + when (warn_missing_sigs || warn_pat_syns) + (mapM_ add_pat_syn_warn pat_syns) where add_pat_syn_warn p = add_warn name $ @@ -1514,7 +1514,7 @@ warnMissingSignatures gbl_env (addWarnAt (Reason flag) (getSrcSpan name) msg) export_check name - = not warn_only_exported || name `elemNameSet` exports + = warn_missing_sigs || not warn_only_exported || name `elemNameSet` exports ; add_sig_warns } |