diff options
| author | Edward Z. Yang <ezyang@cs.stanford.edu> | 2017-05-15 21:17:45 -0700 |
|---|---|---|
| committer | Edward Z. Yang <ezyang@cs.stanford.edu> | 2017-05-16 18:59:53 -0700 |
| commit | d9e9a9b3016a05e6153de3803998877f91c6cdf4 (patch) | |
| tree | 053ab552a3be5b95502bf94146d0d19a27ae2386 /testsuite/.gitignore | |
| parent | cec7d580c2c033c3aaeba093752328d8f3635cd0 (diff) | |
| download | haskell-d9e9a9b3016a05e6153de3803998877f91c6cdf4.tar.gz | |
Fix #13703 by correctly using munged names in ghc-pkg.
Summary:
Cabal internal libraries are implemented using a trick, where the 'name'
field in ghc-pkg registration file is munged into a new form to keep
each internal library looking like a distinct package to ghc-pkg and
other tools; e.g. the internal library q from package p is named
z-p-z-q.
Later, Cabal library got refactored so that we made a closer distinction
between these "munged" package names and the true package name of a
package. Unfortunately, this is an example of a refactor for clarity in
the source code which ends up causing problems downstream, because the
point of "munging" the package name was to make it so that ghc-pkg and
similar tools transparently used MungedPackageName whereever they
previously used PackageName (in preparation for them learning proper
syntax for package name + component name). Failing to do this meant
that internal libraries from the same package (but with different
names) clobber each other.
This commit search-replaces most occurrences of PackageName in
ghc-pkg and turns them into MungedPackageName. Otherwise there
shouldn't be any functional differenes.
Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Test Plan: validate
Reviewers: bgamari, austin
Subscribers: rwbarton, thomie
GHC Trac Issues: #13703
Differential Revision: https://phabricator.haskell.org/D3590
Diffstat (limited to 'testsuite/.gitignore')
| -rw-r--r-- | testsuite/.gitignore | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/testsuite/.gitignore b/testsuite/.gitignore index 21920ab4fe..e6934f966a 100644 --- a/testsuite/.gitignore +++ b/testsuite/.gitignore @@ -109,6 +109,7 @@ mk/ghcconfig*_test___spaces_ghc*.exe.mk /tests/boxy/T2193 /tests/cabal/1750.hs /tests/cabal/1750.out +/tests/cabal/T13703.package.conf/ /tests/cabal/T1750.hs /tests/cabal/T1750.out /tests/cabal/cabal01/dist/ |