diff options
| author | sheaf <sam.derbyshire@gmail.com> | 2023-05-15 15:23:49 +0200 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2023-05-15 18:03:00 -0400 |
| commit | 4d29ecdfcc79ad663e066d9f7d6d17b64c8c6c41 (patch) | |
| tree | 985890c63aee54a2e94e31aa85cbec44652987b9 /testsuite/tests/backpack/should_fail/bkpfail47.stderr | |
| parent | d69cbd78999071d2d6479be40ae90ddd83b9942a (diff) | |
| download | haskell-4d29ecdfcc79ad663e066d9f7d6d17b64c8c6c41.tar.gz | |
Migrate errors to diagnostics in GHC.Tc.Module
This commit migrates the errors in GHC.Tc.Module to use the new
diagnostic infrastructure.
It required a significant overhaul of the compatibility checks between
an hs-boot or signature module and its implementation; we now use
a Writer monad to accumulate errors; see the BootMismatch datatype
in GHC.Tc.Errors.Types, with its panoply of subtypes.
For the sake of readability, several local functions inside the
'checkBootTyCon' function were split off into top-level functions.
We split off GHC.Types.HscSource into a "boot or sig" vs "normal hs file"
datatype, as this mirrors the logic in several other places where we
want to treat hs-boot and hsig files in a similar fashion.
This commit also refactors the Backpack checks for type synonyms
implementing abstract data, to correctly reject implementations that
contain qualified or quantified types (this fixes #23342 and #23344).
Diffstat (limited to 'testsuite/tests/backpack/should_fail/bkpfail47.stderr')
| -rw-r--r-- | testsuite/tests/backpack/should_fail/bkpfail47.stderr | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/testsuite/tests/backpack/should_fail/bkpfail47.stderr b/testsuite/tests/backpack/should_fail/bkpfail47.stderr index 86453f28ea..adb764be16 100644 --- a/testsuite/tests/backpack/should_fail/bkpfail47.stderr +++ b/testsuite/tests/backpack/should_fail/bkpfail47.stderr @@ -1,22 +1,22 @@ [1 of 3] Processing p - [1 of 1] Compiling A[sig] ( p/A.hsig, nothing ) + [1 of 1] Compiling A[sig] ( p\A.hsig, nothing ) [2 of 3] Processing q - [1 of 1] Compiling A[sig] ( q/A.hsig, nothing ) + [1 of 1] Compiling A[sig] ( q\A.hsig, nothing ) [3 of 3] Processing r - [1 of 3] Compiling A[sig] ( r/A.hsig, nothing ) + [1 of 3] Compiling A[sig] ( r\A.hsig, nothing ) -bkpfail47.bkp:10:9: error: +bkpfail47.bkp:10:9: error: [GHC-15843] • Type constructor ‘T’ has conflicting definitions in the module - and its hsig file + and its hsig file. Main module: type role T representational nominal type T :: * -> * -> * data T a b = MkT - Hsig file: type role T nominal representational - type T :: * -> * -> * - data T a b + Hsig file: type role T nominal representational + type T :: * -> * -> * + data T a b The roles are not compatible: - Main module: [representational, nominal] - Hsig file: [nominal, representational] + Main module: [nominal, representational] + Hsig file: [representational, nominal] • while merging the signatures from: • p[A=<A>]:A • q[A=<A>]:A |