diff options
| author | Bartosz Nitka <niteria@gmail.com> | 2017-05-31 10:47:03 -0700 |
|---|---|---|
| committer | Bartosz Nitka <niteria@gmail.com> | 2017-07-18 05:27:01 -0700 |
| commit | b8fec6950ad99cbf11cd22698b8d5ab35afb828f (patch) | |
| tree | da026b84ac5cfbf34c910d526fda9e106298cccb /utils/check-ppr | |
| parent | 935acb6f0de36822b46f8444199dbc37de784af4 (diff) | |
| download | haskell-b8fec6950ad99cbf11cd22698b8d5ab35afb828f.tar.gz | |
Make module membership on ModuleGraph faster
When loading/reloading with a large number of modules
(>5000) the cost of linear lookups becomes significant.
The changes here made `:reload` go from 6s to 1s on my
test case.
The bottlenecks were `needsLinker` in `DriverPipeline` and
`getModLoop` in `GhcMake`.
Test Plan: ./validate
Reviewers: simonmar, austin, bgamari
Subscribers: thomie, rwbarton
Differential Revision: https://phabricator.haskell.org/D3703
Diffstat (limited to 'utils/check-ppr')
| -rw-r--r-- | utils/check-ppr/Main.hs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/utils/check-ppr/Main.hs b/utils/check-ppr/Main.hs index 47a95659ff..2fd44b2be0 100644 --- a/utils/check-ppr/Main.hs +++ b/utils/check-ppr/Main.hs @@ -77,7 +77,7 @@ parseOneFile libdir fileName = do _ <- load LoadAllTargets graph <- getModuleGraph let - modSum = case filter modByFile graph of + modSum = case filter modByFile (mgModSummaries graph) of [x] -> x xs -> error $ "Can't find module, got:" ++ show (map (ml_hs_file . ms_location) xs) |