diff options
| author | Wolfram Sang <wsa+renesas@sang-engineering.com> | 2020-08-04 10:14:38 +0200 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2020-08-29 17:38:06 +0200 |
| commit | 34806fc4e7090b34e32fa1110d546ab5ce01a6a0 (patch) | |
| tree | 584d6972b18dddba856b4b42152404731e18a42a | |
| parent | 349b18f5660548f8aaae4014a8fbb1a3e71d89c2 (diff) | |
| download | i2c-tools-git-34806fc4e7090b34e32fa1110d546ab5ce01a6a0.tar.gz | |
tools: i2ctransfer: add check for returned length from driver
Emit a warning if the bus master driver in the kernel did not set the
message length correctly with I2C_M_RECV_LEN. This can be determined
from the returned value in the buffer.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
| -rw-r--r-- | tools/i2ctransfer.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/tools/i2ctransfer.c b/tools/i2ctransfer.c index b0e8d43..f2a4df8 100644 --- a/tools/i2ctransfer.c +++ b/tools/i2ctransfer.c @@ -88,7 +88,12 @@ static void print_msgs(struct i2c_msg *msgs, __u32 nmsgs, unsigned flags) int recv_len = msgs[i].flags & I2C_M_RECV_LEN; int print_buf = (read && (flags & PRINT_READ_BUF)) || (!read && (flags & PRINT_WRITE_BUF)); - __u16 len = recv_len ? msgs[i].buf[0] + 1 : msgs[i].len; + __u16 len = msgs[i].len; + + if (recv_len && print_buf && len != msgs[i].buf[0] + 1) { + fprintf(stderr, "Correcting wrong msg length after recv_len! Please fix the I2C driver and/or report.\n"); + len = msgs[i].buf[0] + 1; + } if (flags & PRINT_HEADER) { fprintf(output, "msg %u: addr 0x%02x, %s, len ", |