summaryrefslogtreecommitdiff
path: root/client
diff options
context:
space:
mode:
authortmarkwalder <tmark@isc.org>2017-06-21 10:09:43 -0400
committertmarkwalder <tmark@isc.org>2017-06-21 10:09:43 -0400
commit251bb4b903f498785d106a222dd218e3c887e6e6 (patch)
treed804259afadc56990755dec3cf84e3cf88d49c8e /client
parent8c785e79414e524d7998c3a8f382620b8b5c40f8 (diff)
downloadisc-dhcp-251bb4b903f498785d106a222dd218e3c887e6e6.tar.gz
[master] Fixed crash in dhclient when de-preferencing a lease
Merges in rt44373.
Diffstat (limited to 'client')
-rw-r--r--client/dhc6.c12
1 files changed, 10 insertions, 2 deletions
diff --git a/client/dhc6.c b/client/dhc6.c
index f7cc90fe..683bbab9 100644
--- a/client/dhc6.c
+++ b/client/dhc6.c
@@ -1,7 +1,7 @@
/* dhc6.c - DHCPv6 client routines. */
/*
- * Copyright (c) 2012-2016 by Internet Systems Consortium, Inc. ("ISC")
+ * Copyright (c) 2012-2017 by Internet Systems Consortium, Inc. ("ISC")
* Copyright (c) 2006-2010 by Internet Systems Consortium, Inc. ("ISC")
*
* Permission to use, copy, modify, and distribute this software for any
@@ -4364,6 +4364,7 @@ dhc6_check_times(struct client_state *client)
TIME renew=MAX_TIME, rebind=MAX_TIME, depref=MAX_TIME,
lo_expire=MAX_TIME, hi_expire=0, max_ia_starts = 0, tmp;
int has_addrs = ISC_FALSE;
+ int has_preferred_addrs = ISC_FALSE;
struct timeval tv;
lease = client->active_lease;
@@ -4392,6 +4393,10 @@ dhc6_check_times(struct client_state *client)
if (tmp < depref)
depref = tmp;
+
+ if (!(addr->flags & DHC6_ADDR_EXPIRED)) {
+ has_preferred_addrs = ISC_TRUE;
+ }
}
if (!(addr->flags & DHC6_ADDR_EXPIRED)) {
@@ -4550,7 +4555,10 @@ dhc6_check_times(struct client_state *client)
break;
default:
- log_fatal("Impossible condition at %s:%d.", MDL);
+ if (has_preferred_addrs) {
+ log_fatal("Impossible condition, state %d at %s:%d.",
+ client->state, MDL);
+ }
}
/* Separately, set a time at which we will depref and expire