diff options
| author | Shawn Routhier <sar@isc.org> | 2012-10-16 15:05:24 -0700 |
|---|---|---|
| committer | Shawn Routhier <sar@isc.org> | 2012-10-16 15:05:24 -0700 |
| commit | 0f750c4fb19823f622cfde356ac7f7aa2c9a3427 (patch) | |
| tree | fea3ccc473e35832e12a0a3d0a576ea9b2174846 /omapip/support.c | |
| parent | 881442e20f455fb1dc21600390cc5aecae08fd72 (diff) | |
| download | isc-dhcp-0f750c4fb19823f622cfde356ac7f7aa2c9a3427.tar.gz | |
[master]
[rt23833]
Clean up a number of items identified by the Coverity
static analysis tool. Runs courtesy of Red Hat.
Diffstat (limited to 'omapip/support.c')
| -rw-r--r-- | omapip/support.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/omapip/support.c b/omapip/support.c index c82dcc8c..7768c6e6 100644 --- a/omapip/support.c +++ b/omapip/support.c @@ -3,7 +3,8 @@ Subroutines providing general support for objects. */ /* - * Copyright (c) 2004-2007,2009 by Internet Systems Consortium, Inc. ("ISC") + * Copyright (c) 2009,2012 by Internet Systems Consortium, Inc. ("ISC") + * Copyright (c) 2004-2007 by Internet Systems Consortium, Inc. ("ISC") * Copyright (c) 1999-2003 by Internet Software Consortium * * Permission to use, copy, modify, and distribute this software for any @@ -551,8 +552,14 @@ isc_result_t omapi_object_update (omapi_object_t *obj, omapi_object_t *id, if (status != ISC_R_SUCCESS && status != DHCP_R_UNCHANGED) return status; } + + /* + * For now ignore the return value. I'm not sure if we want to + * generate an error if we can't set the handle value. If we + * do add a check we probably should allow unchanged and notfound + */ if (handle) - omapi_set_int_value (obj, id, "remote-handle", (int)handle); + (void) omapi_set_int_value (obj, id, "remote-handle", (int)handle); status = omapi_signal (obj, "updated"); if (status != ISC_R_NOTFOUND) return status; |