[master] Corrects medium impact issues reported by Coverity.

    Merges in rt36933

1 files changed, 5 insertions, 6 deletions

diff --git a/server/ddns.c b/server/ddns.c
index aba57e7f..6cbd3e3d 100644
--- a/server/ddns.c
+++ b/server/ddns.c
@@ -236,10 +236,9 @@ ddns_updates(struct packet *packet, struct lease *lease, struct lease *old,
 			goto out;
 		}
 
-		buffer_allocate (&ddns_fwd_name.buffer,
-				 ddns_hostname.len + ddns_domainname.len + 2,
-				 MDL);
-		if (ddns_fwd_name.buffer) {
+		if (buffer_allocate (&ddns_fwd_name.buffer,
+				     ddns_hostname.len +
+				     ddns_domainname.len + 2, MDL)) {
 			ddns_fwd_name.data = ddns_fwd_name.buffer->data;
 			data_string_append (&ddns_fwd_name, &ddns_hostname);
 			ddns_fwd_name.buffer->data[ddns_fwd_name.len] = '.';
@@ -438,8 +437,8 @@ ddns_updates(struct packet *packet, struct lease *lease, struct lease *old,
 	}
 
 	if (s1) {
-		buffer_allocate(&ddns_cb->rev_name.buffer, rev_name_len, MDL);
-		if (ddns_cb->rev_name.buffer != NULL) {
+		if (buffer_allocate(&ddns_cb->rev_name.buffer,
+				    rev_name_len, MDL)) {
 			struct data_string *rname = &ddns_cb->rev_name;
 			rname->data = rname->buffer->data;