summaryrefslogtreecommitdiff
path: root/jackd
diff options
context:
space:
mode:
authorPaul Davis <paul@linuxaudiosystems.com>2016-02-11 17:47:38 -0500
committerPaul Davis <paul@linuxaudiosystems.com>2016-02-11 17:47:38 -0500
commit7ae3b2be3c4f77f023f79f67430cf45fb97cab8d (patch)
tree8aeea09f1298e6da892f9b63753c9fc1e307007a /jackd
parent5f6361e530b560b43614282f5141fd17ee3ebc9e (diff)
downloadjack1-7ae3b2be3c4f77f023f79f67430cf45fb97cab8d.tar.gz
Revert "Set driver port order metadata".
The "client" argument being passed to jack_set_property() is jack_client_internal_t*, not jack_client_t* as expected, which leads to a crash. Using client->private_client (which is a jack_client_t*) causes deadlock because do_request() is called recursively. The goal here is good, but it can't be accomplished in this way. This reverts commit 439e47da1a179f62ce9e6601851b4f90381da0de.
Diffstat (limited to 'jackd')
-rw-r--r--jackd/engine.c11
1 files changed, 0 insertions, 11 deletions
diff --git a/jackd/engine.c b/jackd/engine.c
index b92051c..cfac483 100644
--- a/jackd/engine.c
+++ b/jackd/engine.c
@@ -4474,17 +4474,6 @@ next:
req->x.port_info.port_id = port_id;
- if (internal) {
- /* set port order so clients can list ports in the proper order if
- * there are more than 9 driver ports (since the lack of leading zeros
- * breaks sorting by name) */
- char index_str[16];
- snprintf (index_str, sizeof(index_str), "%d", port_id);
- jack_set_property (client, shared->uuid,
- "http://jackaudio.org/metadata/order", index_str,
- "http://www.w3.org/2001/XMLSchema#integer");
- }
-
return 0;
}