diff options
author | Lianbo Jiang <lijiang@redhat.com> | 2019-08-23 20:05:38 +0800 |
---|---|---|
committer | Simon Horman <horms@verge.net.au> | 2019-09-08 13:26:07 +0100 |
commit | a7c4cb8e998571cb3dd62e907935a1e052b15d6c (patch) | |
tree | e2f2ec782d6939a686e9cb9f8cdd798e15e06bdd /util_lib | |
parent | 14ad054e7baa788a6629385ffe5e0f1996b7de02 (diff) | |
download | kexec-tools-a7c4cb8e998571cb3dd62e907935a1e052b15d6c.tar.gz |
Cleanup: move it back from util_lib/elf_info.c
Some code related to vmcore-dmesg.c is put into the util_lib, which
is not very reasonable, so lets move it back and tidy up those code.
In addition, that will also help to limit the size of vmcore-dmesg.txt
in vmcore-dmesg.c instead of elf_info.c.
Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
Diffstat (limited to 'util_lib')
-rw-r--r-- | util_lib/elf_info.c | 48 | ||||
-rw-r--r-- | util_lib/include/elf_info.h | 2 |
2 files changed, 12 insertions, 38 deletions
diff --git a/util_lib/elf_info.c b/util_lib/elf_info.c index 5d0efaa..2bce5cb 100644 --- a/util_lib/elf_info.c +++ b/util_lib/elf_info.c @@ -531,19 +531,7 @@ static int32_t read_file_s32(int fd, uint64_t addr) return read_file_u32(fd, addr); } -static void write_to_stdout(char *buf, unsigned int nr) -{ - ssize_t ret; - - ret = write(STDOUT_FILENO, buf, nr); - if (ret != nr) { - fprintf(stderr, "Failed to write out the dmesg log buffer!:" - " %s\n", strerror(errno)); - exit(54); - } -} - -static void dump_dmesg_legacy(int fd) +static void dump_dmesg_legacy(int fd, void (*handler)(char*, unsigned int)) { uint64_t log_buf, log_buf_offset; unsigned log_end, logged_chars, log_end_wrapped; @@ -604,7 +592,8 @@ static void dump_dmesg_legacy(int fd) */ logged_chars = log_end < log_buf_len ? log_end : log_buf_len; - write_to_stdout(buf + (log_buf_len - logged_chars), logged_chars); + if (handler) + handler(buf + (log_buf_len - logged_chars), logged_chars); } static inline uint16_t struct_val_u16(char *ptr, unsigned int offset) @@ -623,7 +612,7 @@ static inline uint64_t struct_val_u64(char *ptr, unsigned int offset) } /* Read headers of log records and dump accordingly */ -static void dump_dmesg_structured(int fd) +static void dump_dmesg_structured(int fd, void (*handler)(char*, unsigned int)) { #define OUT_BUF_SIZE 4096 uint64_t log_buf, log_buf_offset, ts_nsec; @@ -733,7 +722,8 @@ static void dump_dmesg_structured(int fd) out_buf[len++] = c; if (len >= OUT_BUF_SIZE - 64) { - write_to_stdout(out_buf, len); + if (handler) + handler(out_buf, len); len = 0; } } @@ -752,16 +742,16 @@ static void dump_dmesg_structured(int fd) current_idx += loglen; } free(buf); - if (len) - write_to_stdout(out_buf, len); + if (len && handler) + handler(out_buf, len); } -static void dump_dmesg(int fd) +void dump_dmesg(int fd, void (*handler)(char*, unsigned int)) { if (log_first_idx_vaddr) - dump_dmesg_structured(fd); + dump_dmesg_structured(fd, handler); else - dump_dmesg_legacy(fd); + dump_dmesg_legacy(fd, handler); } int read_elf(int fd) @@ -808,22 +798,6 @@ int read_elf(int fd) return 0; } -int read_elf_vmcore(int fd) -{ - int ret; - - ret = read_elf(fd); - if (ret > 0) { - fprintf(stderr, "Unable to read ELF information" - " from vmcore\n"); - return ret; - } - - dump_dmesg(fd); - - return 0; -} - int read_phys_offset_elf_kcore(int fd, unsigned long *phys_off) { int ret; diff --git a/util_lib/include/elf_info.h b/util_lib/include/elf_info.h index c328a1b..4bc9279 100644 --- a/util_lib/include/elf_info.h +++ b/util_lib/include/elf_info.h @@ -30,6 +30,6 @@ int get_pt_load(int idx, unsigned long long *virt_end); int read_phys_offset_elf_kcore(int fd, unsigned long *phys_off); int read_elf(int fd); -int read_elf_vmcore(int fd); +void dump_dmesg(int fd, void (*handler)(char*, unsigned int)); #endif /* ELF_INFO_H */ |