diff options
author | Chris Mumford <cmumford@google.com> | 2019-05-08 17:28:28 -0700 |
---|---|---|
committer | Chris Mumford <cmumford@google.com> | 2019-05-08 17:36:35 -0700 |
commit | b7b86baec9ce47569affc5db54a20a6cc520e0f0 (patch) | |
tree | cab65bf90df889c953b240974c4aa869a95a65d0 /db/dbformat.cc | |
parent | 3e6c000e18519cb22e0a44d0dea45b34daee4ee1 (diff) | |
download | leveldb-b7b86baec9ce47569affc5db54a20a6cc520e0f0.tar.gz |
Using std::ostringstream in key DebugString.
Switching from snprintf to std::ostringstream eliminates
cast warning for (unsigned long long).
PiperOrigin-RevId: 247326681
Diffstat (limited to 'db/dbformat.cc')
-rw-r--r-- | db/dbformat.cc | 23 |
1 files changed, 10 insertions, 13 deletions
diff --git a/db/dbformat.cc b/db/dbformat.cc index 69e8dc6..459eddf 100644 --- a/db/dbformat.cc +++ b/db/dbformat.cc @@ -6,6 +6,8 @@ #include <stdio.h> +#include <sstream> + #include "port/port.h" #include "util/coding.h" @@ -23,25 +25,20 @@ void AppendInternalKey(std::string* result, const ParsedInternalKey& key) { } std::string ParsedInternalKey::DebugString() const { - char buf[50]; - snprintf(buf, sizeof(buf), "' @ %llu : %d", (unsigned long long)sequence, - int(type)); - std::string result = "'"; - result += EscapeString(user_key.ToString()); - result += buf; - return result; + std::ostringstream ss; + ss << '\'' << EscapeString(user_key.ToString()) << "' @ " << sequence << " : " + << static_cast<int>(type); + return ss.str(); } std::string InternalKey::DebugString() const { - std::string result; ParsedInternalKey parsed; if (ParseInternalKey(rep_, &parsed)) { - result = parsed.DebugString(); - } else { - result = "(bad)"; - result.append(EscapeString(rep_)); + return parsed.DebugString(); } - return result; + std::ostringstream ss; + ss << "(bad)" << EscapeString(rep_); + return ss.str(); } const char* InternalKeyComparator::Name() const { |